Fix NIO contract violations in Seqera filesystem#7037
Merged
bentsherman merged 1 commit into260310-seqera-dataset-fsfrom Apr 16, 2026
Merged
Fix NIO contract violations in Seqera filesystem#7037bentsherman merged 1 commit into260310-seqera-dataset-fsfrom
bentsherman merged 1 commit into260310-seqera-dataset-fsfrom
Conversation
- Fix resolveSibling NPE when called on root/shallow paths (NIO contract: return `other` when parent is null) - Guard DatasetInputStream.read() against reads after close() by checking the `open` flag and throwing ClosedChannelException - Use IOException instead of raw Exception in sendStreamingRequest for unknown HTTP status codes - Add null guard in SeqeraDatasetClient.getUserId() to prevent NPE when getUserInfo() returns null - Propagate DirectoryIteratorException from newDirectoryStream filter instead of silently swallowing IOExceptions (per NIO spec) - Rename checkResponse to checkFsResponse in SeqeraDatasetClient to disambiguate from TowerClient.checkResponse Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
jorgee
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 issues found during code review of #6946:
Test plan