Skip to content

fix(call): guard against a missing local state broadcaster when leaving a call #19083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bakiburakogun wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix(call): guard against a missing local state broadcaster when leaving a call #19083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/utils/webrtc/webrtc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,10 @@ export function initWebRtc(signaling, _callParticipantCollection, _localCallPart
// is received before the "leave call" request ends.
localUserInCall = false

localStateBroadcaster.destroy()
localStateBroadcaster = null
if (localStateBroadcaster) {

@Antreesy Antreesy Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you get a stack trace here from your production setup?

console.trace('beforeLeaveCall', token, reconnect, !!localStateBroadcaster)

I assume this code path is being run twice, so this log could capture it -> so you should see two stacks

localStateBroadcaster.destroy()
localStateBroadcaster = null
}
})
signaling.on('leaveCall', function(token, reconnect) {
// When the MCU is used and there is a connection error the call is
Expand Down
Loading