feat(settings): split default camera and microphone settings into separate toggles by max65482 · Pull Request #19034 · nextcloud/spreed

max65482 · 2026-08-19T17:48:24Z

☑️ Resolves

Fix Split default camera and microphone settings into separate toggles #17202

AI (if applicable)

The content of this PR was partly or fully generated using AI (Github Copilot, GPT-5.6 Luna)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

🚧 Tasks

...

🏁 Checklist

🛠️ API Checklist

🚧 Tasks

...

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not possible
📘 API documentation in docs/ has been updated or is not required
🔖 Capability is added or not needed

…les, Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>

Antreesy

Thanks for the contribution!

Needs a backender to review it before continue.

From a quick glance - we can't just drop a config option from v20.1, it needs to be deprecated as minimum; existing values set on server can be migrated to maintain behaviour (previous: true -> audio: true + video: true), client should check if server supports new options, otherwise fall back to pre-existing one (e.g. if new client used with old server)

max65482 · 2026-08-20T18:47:26Z

Thanks for the hint! Added backward and forward compatibility.
(Marking as draft since I haven't fully tested it yet.)

…luna Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>

nickvergessen · 2026-08-28T09:07:51Z

+		}
+
+		$legacyAppSetting = $this->appConfig->getAppValue(self::CALLS_START_WITHOUT_MEDIA);
+		if ($legacyAppSetting !== '') {


Use hasAppKey instead, then you can still use getAppValueBool?

nickvergessen · 2026-08-28T09:07:59Z

+		// If the legacy setting is not set, check the new settings for audio and video separately.
+		$audioAppSetting = $this->appConfig->getAppValue(self::CALLS_START_WITHOUT_AUDIO);
+		$videoAppSetting = $this->appConfig->getAppValue(self::CALLS_START_WITHOUT_VIDEO);
+		if ($audioAppSetting !== '' || $videoAppSetting !== '') {


nickvergessen · 2026-08-28T09:09:48Z

+ *             start-without-audio: bool,
+ *             start-without-video: bool,


Both should have docs.

nickvergessen · 2026-08-28T09:10:04Z

@@ -793,6 +793,8 @@
 *             can-enable-sip: bool,
 *             // Whether calls start without media by default


Should mention the deprecation and what to check instead

nickvergessen · 2026-08-28T09:10:22Z

 			new Entry(Config::EXTERNAL_CALL_SERVICE_FRAME_ORIGINS, ValueType::ARRAY, [], definition: 'JSON array of scheme+host(+port) origins that may be loaded in the iframe.' . PHP_EOL . 'Added to `Content-Security-Policy: frame-src` and the `Permissions-Policy` for camera/microphone'),
 			new Entry(Config::EXTERNAL_CALL_SERVICE_IFRAME_FIELD, ValueType::STRING, '', definition: 'JSON field name in the external service response that contains the iframe URL'),
-			new Entry(Config::CALLS_START_WITHOUT_MEDIA, ValueType::BOOL, false, definition: 'Whether participants start with enabled or disabled audio and video by default'),
+			new Entry(Config::CALLS_START_WITHOUT_MEDIA, ValueType::BOOL, false, definition: 'Deprecated: whether participants start with audio and video disabled by default', deprecated: true),


Should mention what to check instead

nickvergessen · 2026-08-28T09:12:23Z

 	public const BLUR_VIRTUAL_BACKGROUND = 'blur_virtual_background';
+	public const CALLS_START_WITHOUT_AUDIO = 'calls_start_without_audio';
+	public const CALLS_START_WITHOUT_VIDEO = 'calls_start_without_video';
+	/** @deprecated Kept as fallback for existing installations. */


Suggested change

/** @deprecated Kept as fallback for existing installations. */

#[\Deprecated(message: 'Check individual configs for audio and video instead', since: '26.0.0')]

nickvergessen · 2026-08-28T09:14:14Z

 			$event->getConfigValue(),
 		));
+		if ($event->isValid()) {
+			$this->synchronizeMediaPreferences($event->getUserId(), $event->getConfigKey(), $event->getConfigValue());


~~this should happen in …~~ oh there is no post-event

nickvergessen · 2026-08-28T09:16:15Z

 * `email-csv-import` - Whether the endpoint to import a CSV email list as participants exists
 * `config => chat => summary-threshold` (local) - Number of unread messages that should exist to show a "Generate summary" option
-* `config => call => start-without-media` (local) - Boolean, whether media should be disabled when starting or joining a conversation
+* `config => call => start-without-media` (local, deprecated) - Boolean, whether media should be disabled when starting or joining a conversation


Should mention what should be checked instead

max65482 · 2026-08-28T17:50:21Z

Thanks for your review @nickvergessen!
I reflected on this PR again and I'm not sure if that's really worth it. It would introduce a deprecated API setting and compatibility logic in client and server. By experience, compatibility code will be carried indefinitely.
A solution for the original goal - having separate camera and mic settings - is already there: The camera and mic settings from the last call are persisted in the browser storage.
What do you think?

max65482 force-pushed the feat/separate-audio-video-default-setting branch from 1b53244 to 8d37e88 Compare August 19, 2026 18:32

feat: split default camera and microphone settings into separate togg…

8bffb12

…les, Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>

max65482 force-pushed the feat/separate-audio-video-default-setting branch from 8d37e88 to 8bffb12 Compare August 19, 2026 18:36

Antreesy reviewed Aug 20, 2026

View reviewed changes

max65482 marked this pull request as draft August 20, 2026 18:47

max65482 force-pushed the feat/separate-audio-video-default-setting branch 2 times, most recently from 50ee006 to b2fa3c8 Compare August 21, 2026 11:22

add forward and backward compatibility, Assisted-by: Copilot:gpt-5.6-…

ad59add

…luna Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>

max65482 force-pushed the feat/separate-audio-video-default-setting branch from b2fa3c8 to ad59add Compare August 21, 2026 12:09

nickvergessen added this to the ☃️ Next Major (36) milestone Aug 28, 2026

nickvergessen added enhancement feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants labels Aug 28, 2026

nickvergessen reviewed Aug 28, 2026

View reviewed changes

nickvergessen requested changes Aug 28, 2026

View reviewed changes

Navigation Menu

Uh oh!

feat(settings): split default camera and microphone settings into separate toggles - #19034

feat(settings): split default camera and microphone settings into separate toggles#19034
max65482 wants to merge 2 commits into
nextcloud:mainfrom
max65482:feat/separate-audio-video-default-setting

max65482 commented Aug 19, 2026 •

edited

Loading

Uh oh!

Antreesy left a comment

Uh oh!

max65482 commented Aug 20, 2026

Uh oh!

nickvergessen Aug 28, 2026

Uh oh!

nickvergessen Aug 28, 2026

Uh oh!

nickvergessen Aug 28, 2026

Uh oh!

nickvergessen Aug 28, 2026

Uh oh!

nickvergessen Aug 28, 2026

Uh oh!

nickvergessen Aug 28, 2026

Uh oh!

nickvergessen Aug 28, 2026

Uh oh!

nickvergessen Aug 28, 2026

Uh oh!

max65482 commented Aug 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -793,6 +793,8 @@
		* can-enable-sip: bool,
		* // Whether calls start without media by default

	/** @deprecated Kept as fallback for existing installations. */
	#[\Deprecated(message: 'Check individual configs for audio and video instead', since: '26.0.0')]

Uh oh!

Conversation

max65482 commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☑️ Resolves

AI (if applicable)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🚧 Tasks

🏁 Checklist

🛠️ API Checklist

🚧 Tasks

🏁 Checklist

Uh oh!

Antreesy left a comment

Choose a reason for hiding this comment

Uh oh!

max65482 commented Aug 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max65482 commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

max65482 commented Aug 19, 2026 •

edited

Loading

max65482 commented Aug 28, 2026 •

edited

Loading