Skip to content

refactor: Add strict property/parameter typing to OCP\HintException#59713

Open
joshtrichards wants to merge 1 commit intomasterfrom
jtr/refactor-HintException-typing
Open

refactor: Add strict property/parameter typing to OCP\HintException#59713
joshtrichards wants to merge 1 commit intomasterfrom
jtr/refactor-HintException-typing

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

  • Resolves: #

Summary

Changes:

  • Added declare(strict_types=1)
  • Typed constructor params:
  • Typed property with constructor property promotion
  • Simplified getHint() to a direct string check

Why:

  • Stronger static analysis
  • Clearer public API contract
  • Less boilerplate
  • Same runtime behavior for valid callers

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (yes, but manually reviewed)

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Apr 18, 2026
@joshtrichards joshtrichards marked this pull request as ready for review April 20, 2026 13:27
@joshtrichards joshtrichards requested a review from a team as a code owner April 20, 2026 13:27
@joshtrichards joshtrichards requested review from artonge, leftybournes, nfebe and salmart-dev and removed request for a team April 20, 2026 13:27
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Apr 20, 2026
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants