fix: OCP\Color bug, reduce interpolation bias, harden, modernize#59712
fix: OCP\Color bug, reduce interpolation bias, harden, modernize#59712joshtrichards wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
|
@copilot Fix test failures that are merely that result of the introduction of round() and thus mean we need to adjust tests for/in this PR. Note unrelated test failures for further human review (though feel free to analyze and make suggestions about them too). |
Agent-Logs-Url: https://github.com/nextcloud/server/sessions/9c83fd78-4690-4e09-b22e-8665110de9e6 Co-authored-by: joshtrichards <1731941+joshtrichards@users.noreply.github.com>
Fixed in aa402a3. The only CI failure was a php-cs-fixer style issue — the project requires Regarding test failures from Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot revert your commits |
Summary
Found while experimenting with using GHCP to do opportunistic code analysis.
Changes:
blueF()now uses$this->bmixPalette()requires at least 2 stepsalphaBlending()requires opacity in0.0..1.0round()instead of raw truncation for better interpolation qualityTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)