Skip to content

fix: Allow num_buckets to be equal as min_bucket#56902

Merged
Koc merged 1 commit intomasterfrom
bugfix/allow-max-buckets-to-be-equal-to-num-buckets
Apr 20, 2026
Merged

fix: Allow num_buckets to be equal as min_bucket#56902
Koc merged 1 commit intomasterfrom
bugfix/allow-max-buckets-to-be-equal-to-num-buckets

Conversation

@Koc
Copy link
Copy Markdown
Contributor

@Koc Koc commented Dec 7, 2025

Summary

We have next configuration for Multibucket Object Store

'objectstore_multibucket' => [
        'class' => 'Object\\Storage\\Backend\\Class',
        'arguments' => [
                'min_bucket' => 100,
                'num_buckets' => 100,
        ],
],

This needed to separate system files from a user files. So, system files will be stored in nextcloud-0 and user files in nextcloud-100. But the problem is such configuration not works as expected due to division by zero. This PR aims to fix that.

Checklist

@Koc Koc requested a review from a team as a code owner December 7, 2025 22:08
@Koc Koc requested review from ArtificialOwl and icewind1991 and removed request for a team December 7, 2025 22:08
@Koc Koc added the bug label Dec 7, 2025
@Koc Koc requested review from CarlSchwan and salmart-dev December 7, 2025 22:08
@Koc Koc force-pushed the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch 2 times, most recently from f64aa95 to 7848dfb Compare December 7, 2025 22:19
@Koc Koc force-pushed the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch from 7848dfb to 8577bc5 Compare February 15, 2026 16:44
@Koc Koc force-pushed the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch from 8577bc5 to 0d2923e Compare April 5, 2026 18:30
@Koc Koc force-pushed the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch from 0d2923e to 61fc80a Compare April 16, 2026 08:59
@Koc
Copy link
Copy Markdown
Contributor Author

Koc commented Apr 16, 2026

@ArtificialOwl @icewind1991 @salmart-dev @CarlSchwan mates, please review 🙏

@Koc Koc force-pushed the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch from 61fc80a to 3856174 Compare April 16, 2026 11:22
@Koc Koc enabled auto-merge April 16, 2026 11:22
@Koc Koc force-pushed the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch 2 times, most recently from 8c8db02 to 1b614a0 Compare April 17, 2026 09:33
@Koc
Copy link
Copy Markdown
Contributor Author

Koc commented Apr 17, 2026

@susnux @come-nc thanx for appovals, but I can't merge due to failed tests (not related to the current PR)

@Koc Koc force-pushed the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch 2 times, most recently from 4ddf6af to 769b23b Compare April 18, 2026 22:34
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch from 769b23b to fcb1021 Compare April 19, 2026 16:28
@Koc Koc merged commit 80eadaf into master Apr 20, 2026
246 of 255 checks passed
@Koc Koc deleted the bugfix/allow-max-buckets-to-be-equal-to-num-buckets branch April 20, 2026 08:27
@nextcloud-bot nextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants