fix(mobile): support server direct editing API for Android v34+ and f…#5805
Draft
elzody wants to merge 1 commit into
Draft
fix(mobile): support server direct editing API for Android v34+ and f…#5805elzody wants to merge 1 commit into
elzody wants to merge 1 commit into
Conversation
…ix iOS 404
Android v34+ now reaches richdocuments via the server's OCP\DirectEditing API
(OfficeDirectEditor/RegisterDirectEditorListener). Update mobile.js to forward
callMobileMessage() calls to window.DirectEditingMobileInterface so that
TextEditorWebView receives the loaded() signal when Collabora fires Frame_Ready.
iOS clients (all versions) use the legacy OCS endpoint. OCSController::createDirect()
now returns the old richdocuments.directView.show/{token} URL for non-Android-v34
callers so they no longer hit the unregistered-editor path and receive a 404.
Expose RegisterDirectEditorListener::MIN_MOBILE_CLIENT_VERSION as public const
so OCSController can reference the version gate without duplication.
Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ix iOS 404
Android v34+ now reaches richdocuments via the server's OCP\DirectEditing API (OfficeDirectEditor/RegisterDirectEditorListener). Update mobile.js to forward callMobileMessage() calls to window.DirectEditingMobileInterface so that TextEditorWebView receives the loaded() signal when Collabora fires Frame_Ready.
iOS clients (all versions) use the legacy OCS endpoint. OCSController::createDirect() now returns the old richdocuments.directView.show/{token} URL for non-Android-v34 callers so they no longer hit the unregistered-editor path and receive a 404.
Expose RegisterDirectEditorListener::MIN_MOBILE_CLIENT_VERSION as public const so OCSController can reference the version gate without duplication.
Assisted-by: ClaudeCode:claude-sonnet-4-6
Summary
TODO
Checklist