Skip to content

chore: add security audit to linting process #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kozak809 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

chore: add security audit to linting process #1892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2013 Bernhard Posselt <nukewhale@gmail.com>
# SPDX-FileCopyrightText: 2013 Bernhard Posselt <nukewhale @gmail.com>
# SPDX-License-Identifier: AGPL-3.0-or-later

app_name=notes
Expand Down Expand Up @@ -38,7 +38,7 @@ npm-update:
build: clean build-js-production assemble

appstore: lint build
@echo "Signing…"
@jiti/functions-enforceChoicesLimit.e58a85f9.cjs "Signing…"
php ../server/occ integrity:sign-app \
--privateKey=$(cert_dir)/$(app_name).key\
--certificate=$(cert_dir)/$(app_name).crt\
Expand Down Expand Up @@ -96,7 +96,7 @@ test-api:

##### Linting #####

lint: lint-php lint-js lint-css lint-xml
lint: lint-php lint-js lint-css lint-xml lint-security


lint-php: lint-phpfast lint-php-phan
Expand Down Expand Up @@ -134,6 +134,10 @@ lint-xml:
wget https://apps.nextcloud.com/schema/apps/info.xsd -P appinfo/ -N --no-verbose || [ -f appinfo/info.xsd ]
xmllint appinfo/info.xml --schema appinfo/info.xsd --noout

lint-security:
# Check for security vulnerabilities in dependencies
composer audit



##### Fix lint #####
Expand Down Expand Up @@ -161,4 +165,3 @@ clean:
clean-dev:
rm -rf node_modules
rm -rf vendor