fix: review of OutOfOffice settings form - #13497
Conversation
|
Thanks, could you take a look at the conflicts?
Newlines are not working anymore |
Signed-off-by: Roberto Guido <info@madbob.org>
Signed-off-by: Roberto Guido <info@madbob.org>
|
I've preferred to entirely drop plaintext/HTML/plaintext conversion, and just use the bare version of the string. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Totally unrequested review of the OOO settings form, migrated to
Nc*components.Boldest changes:
TextEditorwith genericNcTextArea, applied because - after all - HTML editing was already disabled and it is not that differentthis.enabledwas tested as a boolean, while it is always a string), and my personal (and questionable!) opinion is that hiding unrequired components from the crowded settings panel helps in making it more readableFixes #9975