Skip to content

fix(lscoljob): disable Qt's decompression check to allow listing of really large folders again #9988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nilsding wants to merge 1 commit into
base: master
Choose a base branch
from

fix(lscoljob): disable Qt's decompression check to allow listing of r…

6067935
Select commit
Loading
Failed to load commit list.
Draft

fix(lscoljob): disable Qt's decompression check to allow listing of really large folders again #9988

fix(lscoljob): disable Qt's decompression check to allow listing of r…
6067935
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 7, 2026 in 59m 32s

Quality Gate failed

Failed conditions
21 Security Hotspots
E Maintainability Rating on New Code (required ≥ A)
14 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 379 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "algorithm" of type "enum OCC::RemotePermissions::MountedPermissionAlgorithm" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6Pq&open=AZ4DRfdHYVavbbx2F6Pq&pullRequest=9988

Check warning on line 397 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "ll" of type "long long" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6Ps&open=AZ4DRfdHYVavbbx2F6Ps&pullRequest=9988

Check warning on line 515 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6PM&open=AZ4DRfdHYVavbbx2F6PM&pullRequest=9988

Check failure on line 379 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 67 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6Pp&open=AZ4DRfdHYVavbbx2F6Pp&pullRequest=9988

Check warning on line 640 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "isEmpty()" to check whether the container is empty or not. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6Pu&open=AZ4DRfdHYVavbbx2F6Pu&pullRequest=9988

Check warning on line 314 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "account" of type "class QSharedPointer<class OCC::Account>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6PR&open=AZ4DRfdHYVavbbx2F6PR&pullRequest=9988

Check warning on line 494 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "properties" of type "class QList<class QByteArray>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6Pt&open=AZ4DRfdHYVavbbx2F6Pt&pullRequest=9988

Check warning on line 1176 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not assign data members in a constructor. Initialize member "useFlow2" in an initialization list. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6PP&open=AZ4DRfdHYVavbbx2F6PP&pullRequest=9988

Check warning on line 335 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "isRootPath" of type "enum OCC::LsColJob::FolderType" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6PS&open=AZ4DRfdHYVavbbx2F6PS&pullRequest=9988

Check warning on line 335 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "account" of type "class QSharedPointer<class OCC::Account>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6PT&open=AZ4DRfdHYVavbbx2F6PT&pullRequest=9988

Check warning on line 382 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "property" of type "class QString" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6Pr&open=AZ4DRfdHYVavbbx2F6Pr&pullRequest=9988

Check warning on line 1025 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6PO&open=AZ4DRfdHYVavbbx2F6PO&pullRequest=9988

Check warning on line 502 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6PN&open=AZ4DRfdHYVavbbx2F6PN&pullRequest=9988

Check failure on line 277 in src/libsync/networkjobs.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4DRfdHYVavbbx2F6PQ&open=AZ4DRfdHYVavbbx2F6PQ&pullRequest=9988
View more details on SonarQubeCloud