Skip to content

feature(signup): migrate simple-signup to standard browser #9969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rello wants to merge 3 commits into
base: master
Choose a base branch
from

Merge branch 'master' into codex/add-nc-account-setup

1946cf0
Select commit
Loading
Failed to load commit list.
Open

feature(signup): migrate simple-signup to standard browser #9969

Merge branch 'master' into codex/add-nc-account-setup
1946cf0
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 20, 2026 in 18m 14s

Quality Gate failed

Failed conditions
27.1% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)
61 New Code Smells (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 58 in src/gui/urischemehandler.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "systray" of type "class OCC::Systray *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz6Sn1POGIojLbD8&open=AZ33sz6Sn1POGIojLbD8&pullRequest=9969

Check warning on line 95 in src/gui/owncloudsetupwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "obj" is "class QObject *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz41n1POGIojLbDb&open=AZ33sz41n1POGIojLbDb&pullRequest=9969

Check warning on line 454 in src/gui/owncloudsetupwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "davException" of type "struct std::pair<class QByteArray, class QByteArray>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz41n1POGIojLbDl&open=AZ33sz41n1POGIojLbDl&pullRequest=9969

Check warning on line 4 in src/gui/urischemehandler.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz22n1POGIojLbDY&open=AZ33sz22n1POGIojLbDY&pullRequest=9969

Check warning on line 454 in src/gui/owncloudsetupwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz41n1POGIojLbDk&open=AZ33sz41n1POGIojLbDk&pullRequest=9969

Check warning on line 1165 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz53n1POGIojLbD3&open=AZ33sz53n1POGIojLbD3&pullRequest=9969

Check failure on line 139 in src/gui/creds/flow2auth.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4CvkVfL-vDBhHF32ZA&open=AZ4CvkVfL-vDBhHF32ZA&pullRequest=9969

Check warning on line 110 in src/gui/creds/flow2auth.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4CvkVfL-vDBhHF32ZB&open=AZ4CvkVfL-vDBhHF32ZB&pullRequest=9969

Check warning on line 35 in src/gui/urischemehandler.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz6Sn1POGIojLbD7&open=AZ33sz6Sn1POGIojLbD7&pullRequest=9969

Check warning on line 469 in src/gui/wizard/owncloudwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "event" of type "class QHideEvent *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sztsn1POGIojLbDO&open=AZ33sztsn1POGIojLbDO&pullRequest=9969

Check warning on line 478 in src/gui/wizard/owncloudwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "event" of type "class QCloseEvent *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sztsn1POGIojLbDP&open=AZ33sztsn1POGIojLbDP&pullRequest=9969

Check warning on line 53 in src/gui/application.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Class has 44 methods, which is greater than the 35 authorized. Split it into smaller classes. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz6pn1POGIojLbEB&open=AZ33sz6pn1POGIojLbEB&pullRequest=9969

Check warning on line 95 in src/gui/owncloudsetupwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "obj" of type "class QObject *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz41n1POGIojLbDc&open=AZ33sz41n1POGIojLbDc&pullRequest=9969

Check failure on line 230 in src/gui/creds/flow2auth.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 28 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ4CvkVfL-vDBhHF32ZE&open=AZ4CvkVfL-vDBhHF32ZE&pullRequest=9969

Check warning on line 1104 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "configLanguage" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz53n1POGIojLbD1&open=AZ33sz53n1POGIojLbD1&pullRequest=9969

Check failure on line 315 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this TOCTOU race condition window when accessing files 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz53n1POGIojLbDo&open=AZ33sz53n1POGIojLbDo&pullRequest=9969

Check warning on line 488 in src/gui/owncloudsetupwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "expectedPath" of type "class QString" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz41n1POGIojLbDm&open=AZ33sz41n1POGIojLbDm&pullRequest=9969

Check warning on line 15 in src/gui/wizard/providersignuppage.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "parent" of type "class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz2ln1POGIojLbDV&open=AZ33sz2ln1POGIojLbDV&pullRequest=9969

Check failure on line 53 in src/gui/wizard/owncloudwizard.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sztsn1POGIojLbDK&open=AZ33sztsn1POGIojLbDK&pullRequest=9969

Check failure on line 132 in src/gui/urischemehandler.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz6Sn1POGIojLbD-&open=AZ33sz6Sn1POGIojLbD-&pullRequest=9969

Check warning on line 112 in src/gui/application.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz6pn1POGIojLbEC&open=AZ33sz6pn1POGIojLbEC&pullRequest=9969

Check failure on line 18 in src/gui/wizard/providersignuppage.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz2ln1POGIojLbDW&open=AZ33sz2ln1POGIojLbDW&pullRequest=9969

Check warning on line 86 in src/gui/wizard/flow2authwidget.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "oldAuth" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz1rn1POGIojLbDR&open=AZ33sz1rn1POGIojLbDR&pullRequest=9969

Check warning on line 4 in src/gui/urischemehandler.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz6Sn1POGIojLbD6&open=AZ33sz6Sn1POGIojLbD6&pullRequest=9969

Check warning on line 682 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "cfg" of type "class OCC::ConfigFile" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ33sz53n1POGIojLbDx&open=AZ33sz53n1POGIojLbDx&pullRequest=9969
View more details on SonarQubeCloud