Skip to content

fix(file-extension): to file, npe #16863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 1 commit into from
Apr 17, 2026
+7 −1
Merged

fix(file-extension): to file, npe #16863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/src/androidTest/java/com/nextcloud/extensions/BitmapDecodeTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ class BitmapDecodeTests {
assertNull(result)
}

@Test
fun testToFileWhenPathIsNullShouldReturnNull() {
val result = null.toFile()
assertNull(result)
}

@Test
fun testToFileWhenFileDoesNotExistShouldReturnNull() {
val nonExistentPath = tempDir.resolve("does_not_exist.jpg")
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/nextcloud/utils/extensions/FileExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ fun Path.toLocalPath(): String = toAbsolutePath().toString()
* @return [File] instance if the file exists, or `null` if the path is null, empty, or non-existent.
*/
@Suppress("ReturnCount")
fun String.toFile(): File? {
fun String?.toFile(): File? {
if (isNullOrEmpty()) {
Log_OC.w(TAG, "given path is null or empty: $this")
return null
Expand Down
Loading