fix(NcAvatar): redirect to guest avatar if avatar doesnt exist#8440
Merged
fix(NcAvatar): redirect to guest avatar if avatar doesnt exist#8440
Conversation
skjnldsv
added
bug
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/avatar-guestFallback
branch
from
64ba23d to
0352328
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8440 +/- ##
=======================================
Coverage 54.58% 54.58%
=======================================
Files 104 104
Lines 3400 3400
Branches 992 993 +1
=======================================
Hits 1856 1856
Misses 1305 1305
Partials 239 239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
approved these changes
Apr 17, 2026
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Nice.
We should also add this option to the library, probably, and use the library here: https://github.com/nextcloud-libraries/nextcloud-router/blob/main/lib/avatar.ts
Contributor
|
/backport to stable8 |
Contributor
|
Maybe we should also handle the error to render a local avatar, when it is not available at all? |
susnux
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Avoid this kind of stuff if an avatar is not generated/accessible
🏁 Checklist
stable8for maintained Vue 2 version or not applicable