[stable8] feat(NcRichContenteditable): allow to pass menuContainer as string#8424
Merged
[stable8] feat(NcRichContenteditable): allow to pass menuContainer as string#8424
menuContainer as string#8424Conversation
- change default value to null (as per upstream) - allow to pass string selector as a prop - resolve selector at mounted() -> initializeTribute() Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
backportbot
bot
added
enhancement
- it's a patch for new Tribute() and should be coupled with it - upstream fix is released but not published on npm Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
backport/8417/stable8
branch
from
13e7eeb to
e609a09
Compare
Antreesy
approved these changes
Apr 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8424 +/- ##
========================================
Coverage 45.99% 45.99%
========================================
Files 194 194
Lines 4890 4890
Branches 1200 1262 +62
========================================
Hits 2249 2249
+ Misses 2555 2553 -2
- Partials 86 88 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8417
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.