Skip to content

feat(NcSelect): use @nextcloud/vue-select 4.0.0#8423

Merged
pringelmann merged 2 commits intomainfrom
feat/vue-select-nextcloud-fork
Apr 15, 2026
Merged

feat(NcSelect): use @nextcloud/vue-select 4.0.0#8423
pringelmann merged 2 commits intomainfrom
feat/vue-select-nextcloud-fork

Conversation

@pringelmann
Copy link
Copy Markdown
Contributor

☑️ Resolves

Removes the stale TODO in NcSelect by switching from vue-select beta to NC fork.

🚧 Notes

  • CSS is inlined in the bundle, so the separate .../dist/vue-select.css import is gone.
  • @nextcloud/vue-select is inlined in vitest.config.ts so its bundled CSS import goes through Vite's transform.
  • The fork wires up the limit prop, which was a no-op in upstream beta.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@pringelmann pringelmann added this to the 9.6.0 milestone Apr 15, 2026
@pringelmann pringelmann self-assigned this Apr 15, 2026
@pringelmann pringelmann added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file technical debt refactor ♻️ Pull request that is neither a fix nor a feature labels Apr 15, 2026
@pringelmann pringelmann force-pushed the feat/vue-select-nextcloud-fork branch from df4f221 to ba433f2 Compare April 15, 2026 07:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.58%. Comparing base (a85904a) to head (fc07e88).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8423      +/-   ##
==========================================
+ Coverage   54.08%   54.58%   +0.50%     
==========================================
  Files         104      104              
  Lines        3400     3400              
  Branches      992      993       +1     
==========================================
+ Hits         1839     1856      +17     
+ Misses       1322     1305      -17     
  Partials      239      239              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy Antreesy modified the milestones: 9.6.0, 9.7.0 Apr 15, 2026
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 15, 2026

@pringelmann tests are related

-e
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann force-pushed the feat/vue-select-nextcloud-fork branch from 15da8a8 to afb371b Compare April 15, 2026 12:21
-e
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann force-pushed the feat/vue-select-nextcloud-fork branch from afb371b to fc07e88 Compare April 15, 2026 12:42
@pringelmann pringelmann merged commit 4e48527 into main Apr 15, 2026
27 checks passed
@pringelmann pringelmann deleted the feat/vue-select-nextcloud-fork branch April 15, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies Pull requests that update a dependency file refactor ♻️ Pull request that is neither a fix nor a feature technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants