feat(NcSelect): use @nextcloud/vue-select 4.0.0#8423
Merged
pringelmann merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
df4f221 to
ba433f2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8423 +/- ##
==========================================
+ Coverage 54.08% 54.58% +0.50%
==========================================
Files 104 104
Lines 3400 3400
Branches 992 993 +1
==========================================
+ Hits 1839 1856 +17
+ Misses 1322 1305 -17
Partials 239 239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
artonge
approved these changes
Apr 15, 2026
susnux
approved these changes
Apr 15, 2026
Contributor
|
@pringelmann tests are related |
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
15da8a8 to
afb371b
Compare
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
afb371b to
fc07e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Removes the stale
TODOinNcSelectby switching fromvue-selectbeta to NC fork.🚧 Notes
.../dist/vue-select.cssimport is gone.@nextcloud/vue-selectis inlined invitest.config.tsso its bundled CSS import goes through Vite's transform.limitprop, which was a no-op in upstream beta.🏁 Checklist
stable8for maintained Vue 2 version or not applicable