drivers/nutdrv_qx_megatec.c: add QX_FLAG_ABSENT to "ups.firmware"…#3438
Open
jimklimov wants to merge 1 commit into
Open
drivers/nutdrv_qx_megatec.c: add QX_FLAG_ABSENT to "ups.firmware"…#3438jimklimov wants to merge 1 commit into
jimklimov wants to merge 1 commit into
Conversation
…devices with all-spaces in that field can still be recognized [networkupstools#3436] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com> Co-authored-by: Jim Klimov <jimklimov+nut@gmail.com> Co-authored-by: Siravijbb <siravijbb@gmail.com>
jimklimov
added
service/daemon start/stop
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit d02483e is temporarily available: NUT-tarballs-PR-3438.zip. |
|
✅ Build nut 2.8.5.4711-master completed (commit ebdae20b5f by @jimklimov)
|
|
✅ Build nut 2.8.5.4711-master completed (commit ebdae20b5f by @jimklimov) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…so devices with all-spaces in that field can still be recognized
Closes: #3436
An UPS returned a reply to the
Iquery which the subdriver interpreted as lack of "ups.firmware" and discarded the device as unsupported, unlessnovendorwas added into the settings (which needs an end-user to discover that this option exists and might help).According to an experiment in that issue discussion, this change should not impact well-behaved devices which report a real manufacturer string here.
One point not decided yet is whether the NUT driver should stick with the returned value (all-spaces or trimmed-empty string), or stick some fallback like
UNKNOWNin there?Thanks @siravijbb