debug: probe fastify-static 9.1.1 test failures (do not merge)#8229
Closed
debug: probe fastify-static 9.1.1 test failures (do not merge)#8229
Conversation
Temporary instrumentation to investigate why integration tests fail on PR #8165 (@fastify/static 9.0.0 -> 9.1.1). Logs whether requests reach the EF proxy, what registry.matchURLPath returns, and whether the static server handles them. Throwaway branch — do not merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Author
|
Closing — original failures on #8165 were flaky CI, confirmed across three runs. No regression from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Throwaway branch off #8165 to investigate why integration tests fail with
@fastify/static9.0.0 → 9.1.1. Do not merge.What this adds
Three
console.errorprobes that bubble throughdevServer.outputinto vitest's failure log:[EF-PROBE] <method> <url> matched=<functionNames>— atsrc/lib/edge-functions/proxy.tsafterregistry.matchURLPath. Tells us whether requests reached the EF proxy and what the registry returned.[STATIC-PROBE] starting; root=<path>— atsrc/utils/static-server.tsboot.[STATIC-PROBE] <method> <url>— on every static-server request.How to read the output
[EF-PROBE]for/ordertest?matched=[]Looking at the ubuntu Integration shard 3/4 logs for
tests/integration/commands/dev/edge-functions.test.ts > should run edge functions in correct order.Cleanup
Delete this branch once we have an answer; revert / never merge.