fix: five memcpy calls in tinystr in tinystr.cpp#197
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
src/PLASMA/TinyXml/base/tinystr.cpp.Vulnerability
V-001src/PLASMA/TinyXml/base/tinystr.cpp:53Description: Five memcpy calls in tinystr.cpp copy data into heap-allocated buffers without validating that the source length fits within the destination buffer. The size variable newlen is computed from the source string length (e.g., strlen(instring) + 1) and used both to allocate the buffer and to copy data, but there is no guard against integer overflow in the size computation or mismatch between allocated size and copy size. A crafted XML document with oversized string values can overflow the heap buffer, overwriting adjacent heap metadata or function pointers.
Changes
src/PLASMA/TinyXml/base/tinystr.cppVerification
Automated security fix by OrbisAI Security