Skip to content

Improve ssl read internal #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josesimoes merged 1 commit into from
Apr 16, 2026
Merged

Improve ssl read internal #3324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/PAL/COM/sockets/ssl/MbedTLS/ssl_read_internal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,24 @@ int ssl_read_internal(int sd, char *data, size_t size)
}

int ret = mbedtls_ssl_read(ssl, (unsigned char *)(data), size);
if (ret < 0)

if (ret == MBEDTLS_ERR_SSL_WANT_READ || ret == MBEDTLS_ERR_SSL_WANT_WRITE)
{
// Non-blocking socket has no data yet — tell caller to retry via select/poll
return SSL_RESULT__WOULD_BLOCK;
}

if (ret == MBEDTLS_ERR_SSL_PEER_CLOSE_NOTIFY || ret == 0)
{
// Peer closed the connection — signal end-of-stream
return 0;
}

if (ret < 0)
{
// Any other error
return SOCK_SOCKET_ERROR;
}

return ret;
}