Skip to content

fix(Jenkins Node): Properly load job parameters#28631

Open
RomanDavydchuk wants to merge 3 commits intomasterfrom
node-4823-community-issue-jenkins-trigger-with-parameters-operation
Open

fix(Jenkins Node): Properly load job parameters#28631
RomanDavydchuk wants to merge 3 commits intomasterfrom
node-4823-community-issue-jenkins-trigger-with-parameters-operation

Conversation

@RomanDavydchuk
Copy link
Copy Markdown
Contributor

@RomanDavydchuk RomanDavydchuk commented Apr 17, 2026

Summary

Jenkins can expose build parameters in different places depending on job type and Jenkins/plugin version, so reading only one field is incomplete.

  • actions is common for older/freestyle-style jobs
  • property is common for Pipeline and newer configurations
  • Both can represent the same ParametersDefinitionProperty, just in different parts of the job JSON
  • If we read only actions, many valid parameterized jobs return “No data” even though parameters exist
  • Reading both makes the node compatible across real-world Jenkins setups and avoids false negatives in the UI
  • Deduplication is needed because property may include parameters that are also returned in actions

Testing

Manual

To manually test:

  1. Run Jenkins, for example using Docker: docker run -p 8080:8080 -p 50000:50000 jenkins/jenkins:lts
  2. Create a pipeline job
  3. Go to "Configure" section of the job and check "This project is parameterized"
  4. Add any parameters you like for testing
  5. Go to n8n, add Jenkins node
  6. Select "Trigger with Parameters" operation, select the pipeline job you created
  7. Try adding the parameter. Check if parameter name is loaded or not (you should see the parameters you created in Jenkins)

Before the fix (no parameters are loaded for the pipeline job):

2026-04-17.20-02-08.mp4

After the fix (parameters are loaded for both pipeline and freestyle jobs):

2026-04-17.20-01-15.mp4

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-4823/community-issue-jenkins-trigger-with-parameters-operation-fails-to-pre
Closes #27991

Review / Merge checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

@RomanDavydchuk RomanDavydchuk marked this pull request as ready for review April 17, 2026 17:08
@Joffcom Joffcom requested a review from yehorkardash April 17, 2026 17:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026

Performance Comparison

Comparing currentlatest master14-day baseline

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-n8n 1269.76 MB 1269.76 MB 1269.76 MB (σ 0.00) +0.0% +0.0%
docker-image-size-runners 386.00 MB 386.00 MB 391.20 MB (σ 9.93) +0.0% -1.3%

Idle baseline with Instance AI module loaded

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
instance-ai-rss-baseline 383.86 MB 342.32 MB 362.79 MB (σ 23.42) +12.1% +5.8%
instance-ai-heap-used-baseline 186.33 MB 186.29 MB 186.40 MB (σ 0.27) +0.0% -0.0%

Memory consumption baseline with starter plan resources

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-heap-used-baseline 115.47 MB 114.54 MB 114.20 MB (σ 0.47) +0.8% +1.1% 🔴
memory-rss-baseline 295.00 MB 332.36 MB 290.22 MB (σ 47.80) -11.2% +1.6%
How to read this table
  • Current: This PR's value (or latest master if PR perf tests haven't run)
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 14-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: ✅ within 1σ | ⚠️ 1-2σ | 🔴 >2σ regression

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jenkins "Trigger with Parameters" operation fails to pre-load job parameters

1 participant