chore: Override protobufjs version to 8.0.1#28612
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportBundle size has no change ✅ |
Contributor
Performance ComparisonComparing current → latest master → 14-day baseline Memory consumption baseline with starter plan resources
docker-stats
Idle baseline with Instance AI module loaded
How to read this table
|
Member
Author
|
Tests seem to pass after this override so I would assume it's pretty safe to apply it |
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant Runner as n8n Workflow Executor
participant Node as AI / Langchain Node
participant Lib as Langchain / Google Libraries
participant Proto as protobufjs (v8.0.1)
participant API as External API (e.g., Vertex AI / gRPC)
Note over Runner,API: Runtime interaction affected by protobufjs version override
Runner->>Node: Trigger node execution
Node->>Lib: Call Langchain integration
Note over Lib,Proto: Serialization Phase
Lib->>Proto: CHANGED: Encode payload (using v8.0.1)
Proto-->>Lib: Encoded Buffer
Lib->>API: Send request (Protobuf/gRPC)
alt Successful Response
API-->>Lib: Return Protobuf response
Note over Lib,Proto: Deserialization Phase
Lib->>Proto: CHANGED: Decode response (using v8.0.1)
Proto-->>Lib: Plain JS Object
Lib-->>Node: Data results
Node-->>Runner: Node output
else Serialization/Compatibility Error
Lib->>Proto: Decode attempt
Proto-->>Lib: Throw Error (e.g., Schema mismatch)
Lib-->>Node: Execution Error
Node-->>Runner: Node failed
end
Member
Author
|
Issues with current protobufjs version were resolved via updating to 7.5.5, so let's ignore this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump protobufjs version via override to fix an existing vulnerability in the current protobufjs package.
CI passes, but passing to @mutdmour for review in case there's some extra checks that should be done.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SEC-606
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)