revert: Make Wait node fully durable by removing in-memory execution path#28538
Merged
shortstacked merged 1 commit intomasterfrom Apr 16, 2026
Merged
revert: Make Wait node fully durable by removing in-memory execution path#28538shortstacked merged 1 commit intomasterfrom
shortstacked merged 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Performance ComparisonComparing current → latest master → 14-day baseline docker-stats
Idle baseline with Instance AI module loaded
Memory consumption baseline with starter plan resources
How to read this table
|
gml3ff
approved these changes
Apr 16, 2026
gml3ff
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for submitting this.
8 tasks
Contributor
|
Successfully created backport PR for |
8 tasks
Contributor
|
Successfully created backport PR for |
Merged
Contributor
|
Got released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #27066 (
f025a786e75ec962fcaca469c107324eea8548a3).This restores the original Wait node behavior where waits shorter than 65 seconds run in-memory via
setTimeout, and removes the DB-server-clock-anchored scheduling infrastructure introduced in the reverted PR.What is restored:
< 65sin-memory execution pathDate.now()-based timinggetWaitingExecutions()without lookahead windowWhat is removed:
ClockRepositoryandDbClockService(DB server clock syncing)n8n_db_clock_skew_msPrometheus gaugeReview / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)