charts/gitlab-ci-pipelines-exporter: secret naming and redis resources (0.3.6)#90
Open
laimis9133 wants to merge 2 commits into
Open
charts/gitlab-ci-pipelines-exporter: secret naming and redis resources (0.3.6)#90laimis9133 wants to merge 2 commits into
laimis9133 wants to merge 2 commits into
Conversation
Correct secret naming from -config to -secret. Add trailing slash for GitLab URL in the comment example. Signed-off-by: Laimis Juzeliunas <asnelaimis@gmail.com>
Adding Redis resource configuration to the chart.
laimis9133
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to change the secret naming for gitlab-ci-pipelines-exporter/templates/secret.yaml from the current
{{ template "app.fullname" . }}-configto{{ template "app.fullname" . }}-secret.The current setup brings back Warnings for users using the Helm chart with ArgoCD deployments:
RepeatedResourceWarning - Resource /ConfigMap/monitoring/gitlab-ci-pipelines-exporter-config appeared 2 times among application resources. This change also follows the naming convention for Kubernetes resources/objects that are consistent across the chart.Redis resource configuratino has also been added as for large GitLab instances the default values are often too small for usage.
An additional minute change is for the GitLab URL link in the commet section adding a trailing slash in the end. Some users have encountered Readiness probe HTTP 503 errors when setting up and a more specific example might be helpful.
Make tests for docs, lint and kubeconform completed. Chart version bumped to 0.3.6 as well.