Add NetEase Cloud Music provider#3640
Conversation
🔒 Dependency Security Report✅ No dependency changes detected in this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae304cc636
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
xiasi0
force-pushed
the
NeteaseCloudMusic
branch
from
ae304cc to
89f5009
Compare
|
Thanks for the heads-up. I cleaned up the branch history and force-pushed. This PR now contains only one commit for the NetEase Cloud Music provider:
The QQ Music commits are no longer part of this PR.\n |
OzGav
left a comment
OzGav
left a comment
There was a problem hiding this comment.
This is an initial review. One of the other guys will check this over as well.
|
Thanks for the initial review. I’ve addressed the points raised in this round in |
…QR route isolation
OzGav
left a comment
OzGav
left a comment
There was a problem hiding this comment.
Other than the need to remove the Chinese strings once testing is complete I dont see anything else noteworthy. Marvin will get to this when he can I just ask for your patience from here.
|
Actually small lint issue |
|
Two small things + the Chinese strings and then this should be good to go :) |
MarvinSchenkel
left a comment
MarvinSchenkel
left a comment
There was a problem hiding this comment.
You forgot the translations. I put them as inline comments now.
|
@MarvinSchenkel All translation items from review #4140315742 have now been updated to English in commit c598240, and I also replied on each inline thread. Could you please take another look when you have time? Thank you. |
MarvinSchenkel
left a comment
MarvinSchenkel
left a comment
There was a problem hiding this comment.
Looks good, thanks for another great music provider @xiasi0 ! 🙏
## Summary - Add NetEase Cloud Music provider documentation in English and Chinese. - Add language switch links between EN/ZH pages. - Add provider icon asset and docs sidebar entry. - Document local API service requirement and QR login flow. ## Related - Music Assistant provider PR: music-assistant/server#3640 - Companion Home Assistant add-on PR: music-assistant/home-assistant-addon#16 ## Notes - This docs update reflects current integration behavior, including local NeteaseCloudMusicApi dependency and entitlement-based playback constraints.
3 participants
Summary
External Service Requirement
api_base_url, defaulthttp://127.0.0.1:3000).Compliance and Access Policy
Audio Quality Notes
Related
Testing