Skip to content

Remove languages.json; it is now in framework#33595

Merged
RomanPudashkin merged 1 commit into
musescore:mainfrom
RomanPudashkin:remove_languages_json
May 27, 2026
Merged

Remove languages.json; it is now in framework#33595
RomanPudashkin merged 1 commit into
musescore:mainfrom
RomanPudashkin:remove_languages_json

Conversation

@RomanPudashkin
Copy link
Copy Markdown
Contributor

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a9e601e4-a189-4fc1-b76d-cefdb49af71c

📥 Commits

Reviewing files that changed from the base of the PR and between 28da5ee and fee689e.

📒 Files selected for processing (5)
  • buildscripts/ci/translation/s3_packandsend.py
  • muse
  • share/locale/CMakeLists.txt
  • share/locale/README.md
  • share/locale/languages.json
💤 Files with no reviewable changes (2)
  • share/locale/CMakeLists.txt
  • share/locale/languages.json

📝 Walkthrough

Walkthrough

This PR consolidates language definitions by moving languages.json from share/locale/ to the muse/framework/languages/resources/ location within the muse submodule. The CI translation script (s3_packandsend.py) is updated to read from the new path, the old file is removed from the CMake install configuration, the muse submodule reference is updated to a new commit containing the language definitions, and the contributing documentation is updated to guide developers to the new location.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required template sections like motivation, CLA acknowledgment, and commit message verification. Fill in the description template sections including motivation for the change, confirmation of code guidelines compliance, and testing verification.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely describes the main change: removing languages.json because it moved to the framework.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RomanPudashkin RomanPudashkin merged commit 8bb4d2a into musescore:main May 27, 2026
15 checks passed
@RomanPudashkin RomanPudashkin deleted the remove_languages_json branch May 27, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants