-
-
Notifications
You must be signed in to change notification settings - Fork 72
✨ Translate for and while from OpenQASM to QC
#1862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
denialhaag
wants to merge
23
commits into
main
Choose a base branch
from
improve-openqasm-translation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
270457a
Claude's first solution
denialhaag a78ff53
Daniel's first cleanup
denialhaag c0cfada
Define emitIntegerExpression
denialhaag 9518633
Split up parseDeclaration
denialhaag 2edd3ae
Split up emitGateCall
denialhaag 7c0dc25
Daniel's second cleanup
denialhaag 7e379f5
Fix linter errors
denialhaag cb39887
Address the Rabbit's comments
denialhaag c390a12
Merge remote-tracking branch 'origin/main' into improve-openqasm-tran…
denialhaag 853879a
Let Claude refactor the translation to rely purely on LLVM concepts
denialhaag 5b1af5f
Generalize conditions
denialhaag 7069858
Generalize declarations
denialhaag d1d4bf2
Generalize assignments
denialhaag 86f0577
Fix broadcasted gate calls
denialhaag 11d0896
Merge remote-tracking branch 'origin/main' into improve-openqasm-tran…
denialhaag 90e61c5
Clean up a bit
denialhaag 2d064f7
Rename parameterConstants
denialhaag 0925bc3
Support broadcasted compound gates
denialhaag f3c8207
Add test case for declaration by measurment
denialhaag 3b1e39b
🎨 Slightly improve implementation
denialhaag eeb94f6
Fix linter errors
denialhaag 0daf1b5
Ignore cppcoreguidelines-pro-bounds-pointer-arithmetic errors
denialhaag 5cb1b20
Remove version method
denialhaag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright (c) 2023 - 2026 Chair for Design Automation, TUM | ||
| * Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH | ||
| * All rights reserved. | ||
| * | ||
| * SPDX-License-Identifier: MIT | ||
| * | ||
| * Licensed under the MIT License | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <cstddef> | ||
| #include <memory> | ||
| #include <string> | ||
| #include <utility> | ||
|
|
||
| namespace qasm3 { | ||
|
|
||
| struct DebugInfo { | ||
| size_t line; | ||
| size_t column; | ||
| std::string filename; | ||
| std::shared_ptr<DebugInfo> parent; | ||
|
|
||
| DebugInfo(const size_t l, const size_t c, std::string file, | ||
| std::shared_ptr<DebugInfo> parentDebugInfo = nullptr) | ||
| : line(l), column(c), filename(std::move(std::move(file))), | ||
| parent(std::move(parentDebugInfo)) {} | ||
|
|
||
| [[nodiscard]] std::string toString() const { | ||
| return filename + ":" + std::to_string(line) + ":" + std::to_string(column); | ||
| } | ||
| }; | ||
|
|
||
| } // namespace qasm3 | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.