Feature - Allow users to be deleted#1592
Open
faloi wants to merge 10 commits into
Open
Conversation
faloi
force-pushed
the
feature-delete-user-account
branch
from
d8fb3a3 to
ebbe9b8
Compare
faloi
force-pushed
the
feature-delete-user-account
branch
from
ebbe9b8 to
290b70d
Compare
luchotc
approved these changes
Mar 16, 2021
luchotc
left a comment
luchotc
left a comment
Contributor
There was a problem hiding this comment.
I haven't played with it locally but this looks flawless 🔥 💯
| private | ||
|
|
||
| def organic_domain_for(user) | ||
| Mumukit::Platform.laboratory.organic_domain(user.last_organization) |
Contributor
There was a problem hiding this comment.
Prefer to explicitly obtain organization from where the user clicked delete profile button
|
|
||
| <div class="row"> | ||
| <div class="col-md-12"> | ||
| <%= t :delete_account_confirmation_email_explain_html, user_email: @user.email, support_email: Rails.configuration.reminder_sender_email %> |
Contributor
There was a problem hiding this comment.
This is not for you to address it @faloi, but we should define another configuration for Mumuki general purpose email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes mumuki/mumuki-domain#86
Allow users to be deleted.
🔜 Future work
I've only included a very basic text version of the confirmation email, it should be extended and complemented with an HTML version.
📸 Screenshots
Step 1 - delete request
Step 2 - delete confirmation, coming from email
Perhaps a bit confusing, because the modal is the same as previous step... we can change the text or the button, whatever.
Step 2 - invalid or expired token
I'm treating both cases the same way for security reasons - after all the user cannot do anything but starting the delete process again.
Step 3 - user disabled
Maybe we can also force a logout here or redirect to a "goodbye" page.