Feature incognito mode#112
Merged
Merged
Conversation
flbulgarelli
force-pushed
the
feature-userless-mode
branch
from
1c28aa4 to
c0e19b8
Compare
luchotc
reviewed
Aug 10, 2020
| and assignments.submission_status = #{Mumuki::Domain::Status::Submission::Passed.to_i}"). | ||
| where('assignments.id is null') | ||
| where('assignments.id is null'). | ||
| order('public.exercises.number asc') |
Contributor
There was a problem hiding this comment.
This ordering logic it's related to next_exercise, not to pending_exercises.
It's an important distinction because we'll use indicators to easily get pending_items but ordering logic is not included there.
Member
Author
There was a problem hiding this comment.
Great, I had that doubt 😄
Member
Author
There was a problem hiding this comment.
Please review it again!
luchotc
approved these changes
Aug 13, 2020
| end | ||
|
|
||
| describe 'next_exercise', organization_workspace: :test do | ||
| # TODO this looks weird. Why do we need a non-polymorphic |
Contributor
There was a problem hiding this comment.
Currently we aren't using indicators for this one as progress is shared between organizations.
This change was made and had to be rolled back because of that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Implement a polymorphic
Incognitouser - in a null-object style - and the foundations of an incognito mode. This concept is required for allowing a userless mode.📝 Details
Mumuki::Domain::Incognitosingleton.*_at(📚)methods for user messages that take a content - as opposed to 📚.*_for(👥)methods that are content messages that take an user as argument🔙 Backward compatibility
This PR should be 100% backwards compatible, since it does not remove any method nor it alters semantics
👀 See also
mumuki/mumuki-laboratory#1450