Remove env.sh#10224
Merged
MarkusPettersson98 merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
MarkusPettersson98
force-pushed
the
remove-envsh
branch
from
9b16b7c to
cde9c91
Compare
Set MACOSX_DEPLOYMENT_TARGET in the cargo build script of the mullvad-daemon crate. Rustc already shells out to xcrun to figure out the system SDKROOT, so no need to do that manually.
MarkusPettersson98
force-pushed
the
remove-envsh
branch
from
5bade00 to
79d5f60
Compare
hulthe
approved these changes
Apr 16, 2026
Contributor
hulthe
left a comment
hulthe
left a comment
There was a problem hiding this comment.
@hulthe reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
env.shsitting at the repository root. Over time it has been reduced to only setting a few environment variables relevant when building for macOS targets.MACOSX_DEPLOYMENT_TARGETin the cargo build script of themullvad-daemoncrate.rustcalready shells out toxcrunto figure out the systemSDKROOT, so no need to do that manually.This change is