[dashboard] Improve benchmark timeline view#1311
Merged
Conversation
Click a point on the daily benchmark chart to mark it as the report, then click an earlier point to set a baseline — a full comparison renders inline below the chart using the already-loaded reports (no refetching). Role assignment is date-aware: clicking a later point promotes it to report and demotes the current report to baseline. Chart-level changes: - One line per test (totalDuration) instead of one per render/phase - Selected commits shown as labeled ChartsReferenceLine verticals - Baseline/Report chips under the chart - Single shared LineChart for single vs multi-benchmark mode The comparison UI was extracted from BenchmarkDetails into a pure BenchmarkComparisonReportView that takes value/base reports and owns compareBenchmarkReports internally. Entry sort now uses a precomputed priority on ComparisonItem encoding severity (error → success → neutral) and absolute diff magnitude in one number, so the shared view always shows regressions first. Also moves scrollbar-gutter: stable from body to html so the rule applies to the real viewport scroll container and the benchmarks page no longer shifts when the comparison section appears.
Bundle size
Deploy previewhttps://deploy-preview-1311--mui-internal.netlify.app/ PerformanceTotal duration: 16.99 ms +1.89 ms(+12.5%) | Renders: 4 (+0) | Paint: 71.66 ms -2.33 ms(-3.2%)
Check out the code infra dashboard for more information about this PR. |
Janpot
added
the
scope: code-infra
github-actions
Bot
added
the
PR: out-of-date
…-inline-compare # Conflicts: # apps/code-infra-dashboard/src/views/BenchmarkDetails.tsx
oliviertassinari
temporarily deployed
to
dashboard-benchmark-inline-compare - mui-tools-public PR #1311
Render
Destroyed
github-actions
Bot
removed
the
PR: out-of-date
Janpot
changed the title
oliviertassinari
temporarily deployed
to
dashboard-benchmark-inline-compare - code-infra-dashboard PR #1311
Render
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metrics['paint:default']). Use stacked bar charts.https://code-infra-dashboard-pr-1311.onrender.com/repository/mui/base-ui/benchmarks