-
Notifications
You must be signed in to change notification settings - Fork 33
[docs-infra] Add @focus and Linter to Automatically Apply
#1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
16c9fbf
Add `lintJavascriptDemoFocus` eslint plugin
dav-is e8eff01
Add `@focus-start`, `@focus-end`
dav-is da68d0a
handle interplay between focus and highlighted portions
dav-is f3f0047
Add emphasis config
dav-is 807ab40
Allow `@padding` and `@min` override
dav-is 7ed37da
Always return some focus
dav-is 1e22879
Update focusFramesMaxSize to 18
dav-is b10a420
Merge branch 'master' into docs-infra/add-linter
dav-is 4bb784d
pnpm dedupe
dav-is 717d5b8
Use `<mark>` for `@highlight-text`
dav-is fd28123
Update docs
dav-is 66edfb8
Reorder sections
dav-is 908392b
Improve cases where of `@highlight @focus`
dav-is efcc298
Automatically add appropriate padding
dav-is 6645f23
Fix bug where data-hl provided on frame based highlight
dav-is 0b8fdc2
Fix codeblock styles
dav-is 772de1b
Fix background css
dav-is c7d11e8
Fix max height
dav-is 88e3f74
Code review
dav-is 0aa152c
Code review
dav-is 0a74df3
Code review
dav-is 5cc9c02
Fix framing on unknown languages
dav-is b9d537c
Add collapsible indicator
dav-is 0fb4832
Maintain max frame size
dav-is e5a1e00
Take care of CSS for the example toggle
dav-is af29f6f
Improve expand and collapse animation
dav-is f6fc98e
Update doc
dav-is 33c0cb8
Add note
dav-is dc4aa5f
Fix tab switch animation
dav-is fe3d9bd
Improve scroll experience
dav-is 6529001
Fix scrollbar animation
dav-is 60c7011
Remove inline styles
dav-is dbc50ae
Anchor scroll for large blocks
dav-is 428a795
Update comment
dav-is ab64da0
Merge branch 'master' into docs-infra/add-linter
dav-is 2a85eda
Merge branch 'docs-infra/add-linter' of github.com:mui/mui-public int…
dav-is 9289526
Fix scroll jumping
dav-is fbeacfd
Improve scroll anchor performance
dav-is 26f0a0c
Fix horizontal scroll animation
dav-is 650727f
Fix truncated fade css
dav-is cc673ce
Fix first render
dav-is 95a8b6a
Merge branch 'master' into docs-infra/add-linter
dav-is c89941d
Add emphasis options for code blocks
dav-is 759a5ad
Merge branch 'docs-infra/add-linter' of github.com:mui/mui-public int…
dav-is 0b84ea1
Update page index and types.md
dav-is 79f786a
Fix type export
dav-is 62f565b
Merge branch 'master' into docs-infra/add-linter
dav-is 4e7fd55
bump version
dav-is 07fc497
Code Review
dav-is 2a0ecc4
Hide visibility when collapsed
dav-is File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eslint plugins go in code-infra package: packages/code-infra/src/eslint/docsConfig.mjs
For now they're authored in plain javascript. We want to avoid making docs-infra a dependency of code-infra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is in the wrong place, no? It breaks all the other repositories's CI. But it looks specific to mui/mui-public.