[docs-infra] Demo Screenshots as OpenGraph Images#1301
Draft
dav-is wants to merge 5 commits intodocs-infra/improve-live-editingfrom
Draft
[docs-infra] Demo Screenshots as OpenGraph Images#1301dav-is wants to merge 5 commits intodocs-infra/improve-live-editingfrom
dav-is wants to merge 5 commits intodocs-infra/improve-live-editingfrom
Conversation
Deploy previewBundle size
PerformanceTotal duration: 15.47 ms ▼-1.18 ms(-7.1%) | Renders: 4 (+0) | Paint: 65.80 ms ▼-7.22 ms(-9.9%)
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Based on #1232
Update screenshots using
pnpm docs:screenshot.See in GitHub
Uses regular playwright test format added to
docs/app/docs-infra/components/code-highlighter/demos/demo-variants/test.ts:By adding the
file://in a comment, Ctrl+Clicking to open the image works in VS Code.Then add the screenshot as the OpenGraph image at the bottom of the page:
Displayed in Pages Index:
Renders nicely on GitHub:
Renders in rich diff mode: