Skip to content

[code-infra] Use Node v24 instead of v22 #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LukasTy wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[code-infra] Use Node v24 instead of v22 #4423

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e6b570d
[code-infra] Use node v24 instead of v22
LukasTy Mar 24, 2026
04f6cfc
Test the orb from brach
LukasTy Mar 24, 2026
fedd015
downgrade the minimum required version
LukasTy Mar 24, 2026
c724e36
Merge branch 'master' into bump-node-to-24
LukasTy Mar 24, 2026
b93f81c
dedupe
LukasTy Mar 24, 2026
c727160
Trigger CI for moar data
LukasTy Mar 24, 2026
f18d03c
Can we get any more tries for statistical significance?
LukasTy Mar 24, 2026
4f24652
Merge branch 'master' into bump-node-to-24
LukasTy Mar 24, 2026
7c6667d
dedupe
LukasTy Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2.1

orbs:
code-infra: https://raw.githubusercontent.com/mui/mui-public/f48e4f01775b1bbf779f2933fbe76940c248bf4c/.circleci/orbs/code-infra.yml
code-infra: https://raw.githubusercontent.com/mui/mui-public/refs/heads/bump-node-to-v24/.circleci/orbs/code-infra.yml

parameters:
browserstack-force:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
fetch-depth: 0
- name: Set up pnpm
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0
- name: Use Node.js 22.x
- name: Use Node.js 24.x
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: '22.18'
node-version: '24.14'
cache: 'pnpm' # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies
- run: pnpm install
- run: pnpm release:build
Expand Down
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"@tailwindcss/postcss": "4.2.1",
"@types/gtag.js": "0.0.20",
"@types/hast": "3.0.4",
"@types/node": "22.18.13",
"@types/node": "24.12.0",
"@types/react": "19.2.14",
"@types/react-dom": "19.2.3",
"@types/unist": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion examples/tanstack-start-tailwind-css/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@tanstack/devtools-vite": "^0.4.1",
"@tanstack/eslint-config": "^0.3.4",
"eslint": "^10.0.2",
"@types/node": "22.18.13",
"@types/node": "24.12.0",
"@types/react": "^19",
"@types/react-dom": "^19",
"@vitejs/plugin-react": "^5.1.2",
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
command = "pnpm docs:build"

[build.environment]
NODE_VERSION = "22.18"
NODE_VERSION = "24.14"
PNPM_FLAGS = "--frozen-lockfile"

[[plugins]]
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@playwright/test": "1.58.2",
"@tailwindcss/postcss": "4.2.1",
"@testing-library/jest-dom": "6.9.1",
"@types/node": "22.18.13",
"@types/node": "24.12.0",
"@types/react": "19.2.14",
"@types/yargs": "17.0.35",
"@vitejs/plugin-react": "5.1.4",
Expand Down Expand Up @@ -109,7 +109,7 @@
"packageManager": "pnpm@10.32.1",
"engines": {
"pnpm": "10.32.1",
"node": ">=22.18.0"
"node": ">=24.13.0"
Copy link
Copy Markdown
Member Author

@LukasTy LukasTy Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some CI steps are not happy about the latest minor. 🙈
https://app.circleci.com/pipelines/github/mui/base-ui/23241/workflows/9862bcaa-11a7-46f5-9212-ac676d94b9ef/jobs/260066

},
"resolutions": {
"@babel/core": "^7.29.0",
Expand All @@ -118,7 +118,7 @@
"@babel/preset-react": "^7.28.5",
"@babel/preset-typescript": "^7.28.5",
"@babel/types": "^7.29.0",
"@types/node": "22.18.13",
"@types/node": "24.12.0",
"@types/react": "19.2.14",
"@types/react-dom": "^19.2.3"
}
Expand Down
2 changes: 1 addition & 1 deletion playground/vite-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"devDependencies": {
"@eslint/js": "10.0.1",
"@tailwindcss/vite": "4.2.1",
"@types/node": "22.18.13",
"@types/node": "24.12.0",
"@types/react": "19.2.14",
"@types/react-dom": "19.2.3",
"@vitejs/plugin-react": "5.1.4",
Expand Down
Loading
Loading