Skip to content

libmsysm: fix build with newer CMake version - #27268

Merged
striezel merged 1 commit into
msys2:masterfrom
striezel-stash:libmsysm-cmake-build-fix
Jan 9, 2026
Merged

libmsysm: fix build with newer CMake version#27268
striezel merged 1 commit into
msys2:masterfrom
striezel-stash:libmsysm-cmake-build-fix

Conversation

@striezel

@striezel striezel commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@striezel

striezel commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator Author

Builds now, but the paths are wrong:

   @@ -14,19 +14,18 @@
   /ucrt64/lib/cmake/libmsym/libmsymTargets.cmake
   /ucrt64/lib/cmake/libmsym/libmsymTargets-release.cmake
   /ucrt64/lib/libmsym.dll.a
  -/ucrt64/lib/python3.12/
  -/ucrt64/lib/python3.12/site-packages/
  -/ucrt64/lib/python3.12/site-packages/libmsym/
  -/ucrt64/lib/python3.12/site-packages/libmsym/__init__.py
  -/ucrt64/lib/python3.12/site-packages/libmsym/__pycache__/
  -/ucrt64/lib/python3.12/site-packages/libmsym/__pycache__/__init__.cpython-312.pyc
  -/ucrt64/lib/python3.12/site-packages/libmsym/__pycache__/libmsym.cpython-312.pyc
  -/ucrt64/lib/python3.12/site-packages/libmsym/libmsym.py
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/dependency_links.txt
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/PKG-INFO
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/SOURCES.txt
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/top_level.txt
  +/ucrt64/lib/site-packages/
  +/ucrt64/lib/site-packages/libmsym/
  +/ucrt64/lib/site-packages/libmsym/__init__.py
  +/ucrt64/lib/site-packages/libmsym/__pycache__/
  +/ucrt64/lib/site-packages/libmsym/__pycache__/__init__.cpython-313.pyc
  +/ucrt64/lib/site-packages/libmsym/__pycache__/libmsym.cpython-313.pyc
  +/ucrt64/lib/site-packages/libmsym/libmsym.py
  +/ucrt64/lib/site-packages/libmsym-0.2.4-py3.13.egg-info/
  +/ucrt64/lib/site-packages/libmsym-0.2.4-py3.13.egg-info/dependency_links.txt
  +/ucrt64/lib/site-packages/libmsym-0.2.4-py3.13.egg-info/PKG-INFO
  +/ucrt64/lib/site-packages/libmsym-0.2.4-py3.13.egg-info/SOURCES.txt
  +/ucrt64/lib/site-packages/libmsym-0.2.4-py3.13.egg-info/top_level.txt
   /ucrt64/share/
   /ucrt64/share/licenses/
   /ucrt64/share/licenses/libmsym/

Should be /ucrt64/lib/python3.13/site-packages/ instead of /ucrt64/lib/site-packages/.

@striezel
striezel force-pushed the libmsysm-cmake-build-fix branch 3 times, most recently from 616fb68 to 3d247f6 Compare January 9, 2026 09:21
@striezel

striezel commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this for now, because I can't figure out the path fix for this at the moment. I'm currently on a Linux machine and not on Windows, so I can't test this at the moment but have to resort to guess work and pushing to CI to see whether it works out.

If someone else wants to give it a try, feel free to do so.

Edit: Strange. The build from ca. an hour ago succeeded (although with wrong paths), but it's failing now with the same PKGBUILD file.

Edit 2: Python file path problems may not be specific to this package, but to the new Python version 3.13, see #27236 (comment).

Edit 3: According to #27236 (comment) this should be fixed now / in Python package version 3.13.11-4 (70f2ba8). So let's give it another try.

@striezel striezel closed this Jan 9, 2026
@striezel striezel reopened this Jan 9, 2026
@striezel

striezel commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator Author

Yes! Success and proper Python paths on UCRT64. 🎉

  @@ -14,19 +14,19 @@
   /ucrt64/lib/cmake/libmsym/libmsymTargets.cmake
   /ucrt64/lib/cmake/libmsym/libmsymTargets-release.cmake
   /ucrt64/lib/libmsym.dll.a
  -/ucrt64/lib/python3.12/
  -/ucrt64/lib/python3.12/site-packages/
  -/ucrt64/lib/python3.12/site-packages/libmsym/
  -/ucrt64/lib/python3.12/site-packages/libmsym/__init__.py
  -/ucrt64/lib/python3.12/site-packages/libmsym/__pycache__/
  -/ucrt64/lib/python3.12/site-packages/libmsym/__pycache__/__init__.cpython-312.pyc
  -/ucrt64/lib/python3.12/site-packages/libmsym/__pycache__/libmsym.cpython-312.pyc
  -/ucrt64/lib/python3.12/site-packages/libmsym/libmsym.py
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/dependency_links.txt
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/PKG-INFO
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/SOURCES.txt
  -/ucrt64/lib/python3.12/site-packages/libmsym-0.2.4-py3.12.egg-info/top_level.txt
  +/ucrt64/lib/python3.13/
  +/ucrt64/lib/python3.13/site-packages/
  +/ucrt64/lib/python3.13/site-packages/libmsym/
  +/ucrt64/lib/python3.13/site-packages/libmsym/__init__.py
  +/ucrt64/lib/python3.13/site-packages/libmsym/__pycache__/
  +/ucrt64/lib/python3.13/site-packages/libmsym/__pycache__/__init__.cpython-313.pyc
  +/ucrt64/lib/python3.13/site-packages/libmsym/__pycache__/libmsym.cpython-313.pyc
  +/ucrt64/lib/python3.13/site-packages/libmsym/libmsym.py
  +/ucrt64/lib/python3.13/site-packages/libmsym-0.2.4-py3.13.egg-info/
  +/ucrt64/lib/python3.13/site-packages/libmsym-0.2.4-py3.13.egg-info/dependency_links.txt
  +/ucrt64/lib/python3.13/site-packages/libmsym-0.2.4-py3.13.egg-info/PKG-INFO
  +/ucrt64/lib/python3.13/site-packages/libmsym-0.2.4-py3.13.egg-info/SOURCES.txt
  +/ucrt64/lib/python3.13/site-packages/libmsym-0.2.4-py3.13.egg-info/top_level.txt
   /ucrt64/share/
   /ucrt64/share/licenses/
   /ucrt64/share/licenses/libmsym/

Thanks @lazka!

@striezel
striezel marked this pull request as ready for review January 9, 2026 13:39
@striezel

striezel commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator Author

Build is OK, but check failed:

   Pip Check Failed for mingw-w64-ucrt-x86_64-libmsym
  Running `pip check` didn't suceed. Maybe missing dependencies?
  Here is what it failed.
  spglib 2.7.0 requires numpy, which is not installed.

Likely that's related to the recent update of spglib to version 2.7.0 in 0e4f302.

Edit: Adjusted dependencies of spglib in 92c87b9 to avoid that problem in the future.

@striezel
striezel merged commit d39cb31 into msys2:master Jan 9, 2026
19 of 23 checks passed
@striezel
striezel deleted the libmsysm-cmake-build-fix branch January 9, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant