Qt6 compatibility patch 3#398
Merged
Merged
Conversation
- conditionally depend on core5compat module core5compat contains QRegExp and QStringRef classes that are not available in Qt 6 by default. - replaced QString::midRef() with QString::mid() QString::midRef() is not available in Qt 6 due to QStringRef removal. replacing it with QString::mid() is not the best option as this introduces memory allocation, but the easiest one. QStringView can't cover all cases as it is limited in Qt 5. but this can be addressed later with full Qt 6 migration. these changes don't make build with Qt6 possible, but they don't hurt Qt5 build either, and still move Qt6 migration forward.
Contributor
Author
Collaborator
|
Just as reference: |
EtlamGit
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conditionally depend on core5compat module
core5compat contains QRegExp and QStringRef classes that are not available in Qt 6 by default.
replaced QString::midRef() with QString::mid()
QString::midRef() is not available in Qt 6 due to QStringRef removal. replacing it with QString::mid() is not the best option as this introduces memory allocation, but the easiest one.
QStringView can't cover all cases as it is limited in Qt 5. but this can be addressed later with full Qt 6 migration.
these changes don't make build with Qt6 possible, but they don't hurt Qt5 build either, and still move Qt6 migration forward.