Skip to content

Clears NHR on held disable add-on action#25085

Open
chrstinalin wants to merge 2 commits into
mozilla:masterfrom
chrstinalin:#16041-clear-nhr
Open

Clears NHR on held disable add-on action#25085
chrstinalin wants to merge 2 commits into
mozilla:masterfrom
chrstinalin:#16041-clear-nhr

Conversation

@chrstinalin

@chrstinalin chrstinalin commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Fixes mozilla/addons#16041

Description

Clears NHR ('Needs Human Review') when the disable add-on enforcement action is triggered.

Testing

  1. Create a high-profile add-on (i.e any promotion that's not strategic)
  • Create (or upload a new version of) an add-on.
  • Add the promotion via admin in Discovery Addon.
  • Approve that version.
  1. In reviewer tools, set NHR.
  2. It should be in the manual review queue. Its NHR in admin should have is_active=true.
  3. In reviewer tools, Review add-on with 'Add-on disable' enforcement action
  4. Should no longer be in manual queue. Its NHR in admin should have is_active=false.
  5. Should be in second-level approval queue.

For 4), Using ./manage.py fake_cinder_webhook to send a mock amo-legal-disable-addon payload should behave similarly.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.

@chrstinalin chrstinalin requested review from a team and nothingrandom and removed request for a team June 29, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Holding a disable action in 2nd level approval doesn't clear NHR

1 participant