Implement decision overrides in reviewer tools#25075
Conversation
ab458e8 to
31b398c
Compare
31b398c to
e9781d5
Compare
I don't think that should be possible/allowed. If the add-on itself was disabled, we shouldn't allow an approve version, the force-disable should be reverted first separately. |
... Which seems to be the biggest issue here: how do we override a decision that resulted in the add-on being force-disabled, without an appeal ? I can't seem to do this with that patch, with or without selecting approve or approve add-on version policy. |
4701f36 to
7ae18c7
Compare
40c9d36 to
acc175f
Compare
Fixes mozilla/addons#16242
Description
When making a new decision, optionally allows selecting an existing decision to be overridden. When this happens the enforcement action for the existing decision is reversed first.
For complex cases where the decision to be overridden needs to be reversed first, there is an "Override Reverse-only" policy for the first override.
Context
Turned out to be quite a large pr! Properly overriding involved a lot of changes - really the PR is much more about ActionClass changes and not much in the reviewer tools code.
I had claude write the refactoring changes with overrides in abuse/actions.py, abuse/models.py, and the associated tests. I read all the changes, and they seem reasonable, but worth paying special attention nevertheless. I also followed up that refactoring with some manual clean-up.
Naming/terminology suggestions welcome for the new enforcement action and policy 🤷
Testing
Sync your Cinder policies + turn on waffle switch + enable the new Override Reverse-only for reviewer tools in django admin
Try:
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.