Skip to content

Unified highlighter for association search (hl.method=unified) #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kevinschaper wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Unified highlighter for association search (hl.method=unified) #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/src/monarch_py/datamodels/solr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ class SolrQuery(BaseModel):
boost: Optional[str] = None
sort: Optional[str] = None
hl: bool = False
hl_method: Optional[str] = None # e.g. "unified" — reads offsets from postings (storeOffsetsWithPositions)

def add_field_filter_query(self, field: str, value: Union[list, str, None]):
if not value or len(value) == 0:
Expand Down Expand Up @@ -141,6 +142,8 @@ def _solrize(self, value):
return "defType"
elif value == "q_op":
return "q.op"
elif value == "hl_method":
return "hl.method"
elif value is True:
return "true"
elif value is False:
Expand Down
3 changes: 3 additions & 0 deletions backend/src/monarch_py/implementations/solr/solr_query_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ def build_association_query(
query.q = q
query.def_type = "edismax"
query.hl = True
# Unified highlighter reads offsets from the postings (storeOffsetsWithPositions),
# so highlighting no longer needs term vectors on the _t fields.
query.hl_method = "unified"
query.query_fields = association_search_query_fields()
if sort:
query.sort = ", ".join(sort)
Expand Down
Loading