You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.07%. Comparing base (6b16e2c) to head (83df814). ⚠️ Report is 1 commits behind head on main.
I tried running bun run lint locally to see if i could just patch this real quick, but it's hanging on some new errors I haven't gotten before...
Depending on how we feel about #890, that has a number of frontend dependency updates and makes use of now-deprecated methods of eslint config etc. that may resolve this.
Edit: I was apparently missing some dependencies, bun install got me back in working order.
It may also be worth considering pre-commit and pre-commit ci, we use it pretty extensively at ORNL and it's been really nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Summary
Drops
blackas a dependency, in favor of usingruff formatas a formatter. On my machine, it's a ~100x speedup.There's a small change to the makefile too. Instead of using the
--exit-zeroflag inruff check, the command is prefixed with-to continue running even after a non-zero exit code.Checks