Fix critical security vulnerabilities (IDOR, SSRF, XSS) - #62
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 critical security vulnerabilities identified during a full codebase audit:
toggleSaveJob,ignoreJob,unignoreJob,updateJobNotes, andcreateApplicationverified profile ownership but mutated jobs using onlywhere: { id: jobId }, allowing any authenticated user to modify another user's jobs. Fixed by scoping all mutations toprofileId./api/jobs/extract— Server fetched any user-supplied URL with no validation beyond^https?://. AddedisPrivateHostname()to block private/reserved IP ranges (10.x, 172.16-31.x, 192.168.x, 169.254.x, 127.x), localhost, .local, and .internal.JobDescriptionrendered scraped job descriptions (attacker-controlled content) without sanitization. Addedrehype-sanitizeto the Markdown renderer.openrouter.tscontainedOPENROUTER_API_KEYbut lacked aserver-onlyguard. Addedimport "server-only"to fail the build if accidentally imported by a client component.Also includes
docs/audit-findings.md— a comprehensive 60-finding audit document covering security, performance, data syncing, redundancies, and inconsistencies, with exact file locations and fix instructions for future sessions.Test plan
http://localhost,http://169.254.169.254,http://10.0.0.1pnpm tsc --noEmitpasses