Repository navigation
ci: cut duplicate builds, fix release tag naming - #7
Merged
Merged
Conversation
Release naming: - Set include-component-in-tag: false so tags are `vX.Y.Z` like v0.1.0 instead of `comfy-downloader-vX.Y.Z`. - Fix the 0.1.1 CHANGELOG compare link, which pointed at a `comfy-downloader-v0.1.0` tag that never existed. CI waste: - Stop running CI on push to main (and the stale dev branch): main requires these checks with "branch must be up to date", so the push run only repeated the PR run on the identical tree. - Classify PR changes: docs-only PRs skip everything; PRs that don't touch src-tauri/, scripts/, package*.json or workflows (and release-please's version-bump PRs) skip the three native builds. The build steps are skipped rather than the job, on an ubuntu runner, so the required "Build (...)" checks still report. - Quality now runs `npm run build` (typecheck + vite build) so skipped native builds don't hide frontend build breakage. - Share Cargo caches between CI and release builds, saving them only from main so PR caches don't evict main's from the 10 GB quota; key the aria2 cache by target triple and use it in release builds too. - Build macos-x64 on the Apple Silicon runner via cross-compilation instead of the much slower Intel runner (16.5 min in the last run). prepare-aria2 takes ARIA2_TARGET_TRIPLE, builds aria2 for that arch and verifies it with lipo.
mogurt
added a commit
that referenced
this pull request
Sep 28, 2026
The 0.1.1 release has been retagged from `comfy-downloader-v0.1.1` to `v0.1.1`, to match `include-component-in-tag: false` from #7. The old tag was deleted, so the CHANGELOG compare link needs to follow. Docs-only change, so CI skips Quality and the native builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release naming
include-component-in-tag: false, so future tags arevX.Y.Z(matchingv0.1.0) instead ofcomfy-downloader-vX.Y.Z.comfy-downloader-v0.1.0tag that never existed.CI waste
main(Quality + 3 native builds). That is identical to the PR run, becausemainrequires up-to-date checks.vite build. Native builds run whensrc-tauri/,scripts/,package*.jsonor workflows change.macos-x64built on the Intel runner (16.5 min, the long pole).prepare-aria2builds aria2 for the target arch and verifies it withlipo.main's from the 10 GB quota.main(release runs), and PR builds restore them. The aria2 cache is keyed by target triple and used by releases too.devtriggers.Skipped native builds still run as a single echo step on
ubuntu-latest. That's because the ruleset requiresBuild (macos-arm64|macos-x64|windows-x64), and a skipped matrix job would report an unexpanded name that never satisfies it.Testing
release-please-config.jsonparse.node --checkand eslint onscripts/prepare-aria2.mjs; the Windows path still resolves correctly.scripts/and workflows, so all 3 native builds run. The script hash changed, so aria2 is rebuilt from source for both macOS arches. That validates the x86_64 cross-compile (built under Rosetta) and thelipocheck.Notes
release.yml/release-please.ymlchanges only take effect on the next release.comfy-downloader-v0.1.1tag and release are left as they are.