refactor: improve transcription UX and DX by drHuangMHT · Pull Request #1685 · moeru-ai/airi

drHuangMHT · 2026-04-18T16:31:03Z

Description

move transcription related code into composable to improve code readability(tests included).
microphone icon color now reflects whether the transcription is running.
support transcription on portrait orientation.

Linked Issues

Additional Context

github-actions · 2026-04-18T16:31:22Z

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name	Link
🔭 Waiting for approval	For maintainers, approve here

Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

gemini-code-assist

Code Review

This pull request refactors transcription and auto-send logic by extracting it from ChatArea.vue into a new reusable composable, useTranscriptions.ts. This composable is then integrated into both ChatArea.vue and MobileInteractiveArea.vue to provide consistent transcription behavior across layouts. Review feedback suggests removing a redundant try-catch block in the new composable and transitioning from string-prefixed log messages to programmatic identifiers in metadata for better extensibility.

drHuangMHT · 2026-04-20T13:39:57Z

blocked by #1569

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f09a8e2ea1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-25T11:22:57Z

+  {
+    messageInputRef: messageInput,
+    sendMessage: handleSend,
+    isStageTamagotchi: isMobileDevice,


Pass runtime env check instead of mobile-user-agent flag

useTranscriptions expects isStageTamagotchi to mean the Electron runtime, but this call passes isMobileDevice (user-agent mobile detection). On mobile web/Capacitor this evaluates true, so startStreaming treats the app like Electron and skips Web Speech auto-configuration, causing transcription startup to fail when no provider is preconfigured. This regresses the new portrait/mobile transcription path for first-time users.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-25T11:22:57Z

+      clearPendingAutoSend()
+      await stopStreamingTranscription(true)


Send pending transcript when stopping listening

Stopping transcription now cancels the debounce timer unconditionally and never flushes the last pending auto-send, so if a user turns the microphone off during the debounce window their final dictated sentence is left unsent. The previous logic explicitly sent pending text on stop; this refactor drops that behavior and can silently lose expected auto-send delivery in normal use.

Useful? React with 👍 / 👎.

intended behavior

…scription

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cc7a1f169

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-02T03:20:55Z

+  watch(autoSendEnabled, (enabled) => {
+    if (!enabled) {
+      clearPendingAutoSend()
+      console.info('Auto-send disabled', { source: 'useTranscriptions' })
+    }


Stop active transcription when microphone is disabled

This composable no longer reacts to enabled/stream changes, so turning the microphone off in HearingConfig can leave an active transcription session running until manual stop or unmount. That is especially problematic for the Web Speech provider path, which is designed to run continuously until stopStreamingTranscription() is explicitly called. Repro: start transcription, then disable the mic; isListening stays active and speech callbacks can continue even though the mic UI is off.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-02T03:20:55Z

+watch([enabled], () => {
  setupAnalyzer()
 }, { immediate: true })


Re-run analyzer setup when popover or stream changes

setupAnalyzer() now depends on hearingPopoverOpen and stream, but the watcher only observes enabled. If the mic is already enabled, opening the hearing popover (or receiving the stream slightly later) no longer re-initializes the analyzer, so the volume visualization can stay inactive until enabled is toggled again.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-02T03:20:55Z

+        v-if="autoSend"
+        label="Auto send"
+        :variant="autoSend ? 'primary' : 'secondary'"
+        flex-1


Render auto-send toggle even when the value is false

The auto-send button is gated by v-if="autoSend", so it disappears whenever the setting is false. Since autoSendEnabled defaults to false, users cannot enable auto-send from this dialog at all, and once disabled they cannot turn it back on here.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9915f883a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-02T03:58:30Z

 }

-watch([hearingDialogOpen, enabled, stream], () => {
+watch([enabled], () => {


Watch dialog and stream changes when setting up analyzer

setupAnalyzer() still gates on hearingDialogOpen and stream, but the watcher now only tracks enabled. If the mic is already enabled, opening the hearing dialog or receiving the stream later will no longer re-run setup, so the volume meter can remain inactive until enabled is toggled again. This is a regression from the previous dependency set and affects normal UI interaction on mobile.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-02T03:58:30Z

+    })
+
+    it('should expose startListening and stopListening', () => {
+      const { startListening, stopListening } = useTranscriptions(createOptions())


Use the composable's exported method names in tests

The tests destructure startListening/stopListening, but useTranscriptions() now returns startStreamingTranscription/stopStreamingTranscription. As written, these variables are undefined, so calls like await startListening() will throw and make the new test suite fail instead of validating behavior.

Useful? React with 👍 / 👎.

gemini-code-assist Bot reviewed Apr 18, 2026

View reviewed changes

Comment thread packages/stage-layouts/src/composables/use-transcriptions.ts Outdated

Comment thread packages/stage-layouts/src/composables/use-transcriptions.ts Outdated

lietblue added feature Related to feature scope/audio-input Scope related to audio input (ASR, Whisper, STT, etc.) scope/ui Scope related to UI/UX, or interface improve, perf, and bugs labels Apr 21, 2026

drHuangMHT added 5 commits April 25, 2026 17:00

move transcription related code into standalone composable

36e163a

implement transcription on portrait mode

e663936

apply suggestions, refactor for code readability

0f5f594

move isListening to internal state

cd7c0fc

tests

ffa9441

drHuangMHT force-pushed the use-transcriptions branch from 647138c to ffa9441 Compare April 25, 2026 09:04

drHuangMHT and others added 3 commits April 25, 2026 17:13

regenerate lockfile

c25c376

[autofix.ci] apply automated fixes

d1c0a17

Merge branch 'main' into use-transcriptions

f09a8e2

drHuangMHT marked this pull request as ready for review April 25, 2026 11:16

chatgpt-codex-connector Bot reviewed Apr 25, 2026

View reviewed changes

prevent state drilling, component reuse, separate monitoring and tran…

0cc7a1f

…scription

chatgpt-codex-connector Bot reviewed May 2, 2026

View reviewed changes

drHuangMHT added 5 commits May 2, 2026 11:42

hide the button when model binding does not exist

cef84e9

early return when audio input is not enabled

1b0fc17

stop transcription when audio input is disabled

fe73400

properly detect electron environment

a355544

rerun analyzer setup when stream changes

9915f88

drHuangMHT marked this pull request as draft May 2, 2026 03:56

drHuangMHT changed the title ~~refactor: move transcription related code into composable~~ refactor: improve transcription UX and DX May 2, 2026

chatgpt-codex-connector Bot reviewed May 2, 2026

View reviewed changes

		clearPendingAutoSend()
		await stopStreamingTranscription(true)

Uh oh!

Conversation

drHuangMHT commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issues

Additional Context

Uh oh!

github-actions Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

drHuangMHT commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

drHuangMHT May 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

drHuangMHT commented Apr 18, 2026 •

edited

Loading

github-actions Bot commented Apr 18, 2026 •

edited

Loading