BPM tracking improvement by MintKeyphase · Pull Request #1657 · moeru-ai/airi

MintKeyphase · 2026-04-13T11:07:12Z

Description

An attempt in switching to a better BPM detector to improve BPM detection accuracy.

Linked Issues

N/A

Additional Context

First time commit, may make a lot of mistakes. Also I did not remove the old code to minimize changes...

I did not remove the old code to minimize changes, you can beat me up now

gemini-code-assist

Code Review

This pull request integrates the realtime-bpm-analyzer library to enable real-time BPM detection and metronome synchronization. Key updates include modifying the audio worklet to output high-fidelity audio and implementing a metronome that adjusts its interval based on detected BPM and audio energy. Review feedback highlights the need to resolve variable shadowing, properly configure the BPM analyzer instance, and ensure the frequency buffer is updated before energy calculations. Additionally, it is suggested to remove redundant memory allocations and debug workarounds.

gemini-code-assist · 2026-04-13T11:09:37Z

      channels: options.processorOptions?.channels || 1,
      converterType: options.processorOptions?.converterType || ConverterType.SRC_SINC_MEDIUM_QUALITY,
-      bufferSize: options.processorOptions?.bufferSize || 4096,
+      bufferSize: options.processorOptions?.bufferSize || 16384,


Increasing the bufferSize to 16384 increases the memory allocated for inputBuffer and outputBuffer (lines 38-39), but these buffers are not utilized in the process method. If they are indeed redundant, it is recommended to remove them and revert this change to minimize memory overhead.

the increase in necessary due to the increase in sample rate, which in turn allows for a broader spectrum to be recognized by the BPM detector

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5c7dcac88

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

~~I blame Gemini~~

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01143cd987

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

whoops

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cd336d2de

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Refactor audio data analysis method and remove async.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31ff4ff0fd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Thanks Codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6f18558bc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-13T12:14:14Z

      '@better-auth/drizzle-adapter':
        specifier: ^1.6.2
-        version: 1.6.2(@better-auth/core@1.6.2(@better-auth/utils@0.4.0)(@better-fetch/fetch@1.1.21)(@opentelemetry/api@1.9.1)(better-call@1.3.5(zod@4.3.6))(jose@6.2.2)(kysely@0.28.16)(nanostores@1.2.0))(@better-auth/utils@0.4.0)(drizzle-orm@0.45.2(@electric-sql/pglite@0.4.4)(@opentelemetry/api@1.9.1)(@prisma/client@5.22.0)(@types/pg@8.20.0)(better-sqlite3@12.8.0)(kysely@0.28.16)(pg@8.20.0)(postgres@3.4.9))
+        version: 1.6.2(@better-auth/core@1.4.21(@better-auth/utils@0.3.0)(@better-fetch/fetch@1.1.21)(better-call@1.1.8(zod@4.3.6))(jose@6.2.2)(kysely@0.28.16)(nanostores@1.2.0))(@better-auth/utils@0.3.0)(drizzle-orm@0.45.2(@electric-sql/pglite@0.4.4)(@opentelemetry/api@1.9.1)(@prisma/client@5.22.0)(@types/pg@8.20.0)(better-sqlite3@12.8.0)(kysely@0.28.16)(pg@8.20.0)(postgres@3.4.9))


Keep server lockfile on compatible better-auth peer set

This lockfile change rewires apps/server to @better-auth/drizzle-adapter@1.6.2 resolved with @better-auth/core@1.4.21 and @better-auth/utils@0.3.0, which is incompatible with that adapter’s declared peer range (@better-auth/core ^1.6.2, utils 0.4.0). Because pnpm-lock.yaml is authoritative for frozen installs, this can introduce peer conflicts and unstable auth behavior unrelated to the BPM feature.

Useful? React with 👍 / 👎.

Not my job.
(I never touched those)

Thanks codex, again.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9de0bec9ef

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Updated createBeatSyncDetector to be asynchronous and modified the start method to call syncMetronome.

…i-beat-sync into bpm-tracker-mod

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24a88bc2c0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1015724f9f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-14T06:49:14Z

      worklet: analyserWorklet,
      listeners: {
-        onBeat: e => emit('beat', e),
+        onBeat: () => {},


Keep forwarding TempoRA beat callbacks

Changing onBeat to a no-op removes the existing beat signal path from startTemporaAnalyser, so beat listeners now depend entirely on the new realtime-BPM path producing lock messages. In scenarios where that path is delayed or fails (e.g., no compatible audioData messages, analyzer error), beat sync emits nothing and appears broken, whereas the previous implementation still delivered beat events.

Useful? React with 👍 / 👎.

Fallback emits 40 BPM beat events

nekomeowww · 2026-04-16T07:59:07Z

Do you have any evidence that this is better?

MintKeyphase · 2026-04-20T08:07:02Z

Instead of trying to pick up each spike in the audio stream, this tries to get a BPM that would lock in. This should make it more reliable and pick up beats from music that does not have spikes on beat.

nekomeowww · 2026-04-20T08:37:21Z

Would you mind switch the implementation to have them co-exist for a while and let the user to judge which one is better?

So

Have for selecting two implementations We will add data analysis hooks to verify whether the new package works better.

MintKeyphase · 2026-04-20T09:17:34Z

That would actually be a great idea, I'll try doing that. Should I close this PR and start a new one when I am ready, or should the PR be kept open to wait for the changes?

MintKeyphase · 2026-04-22T12:52:25Z

Since there is no activity, I'll be closing this PR and open a new one when I finish implementing the choice.

MintKeyphase added 2 commits April 13, 2026 19:00

Changing out BPM detection method

af8d3a5

I did not remove the old code to minimize changes, you can beat me up now

Merge remote-tracking branch 'upstream/main' into bpm-tracker-mod

a5c7dca

gemini-code-assist Bot reviewed Apr 13, 2026

View reviewed changes

github-actions Bot added feature Related to feature scope/audio-output Scope related to audio output (TTS, Voice cloning, etc.) labels Apr 13, 2026

chatgpt-codex-connector Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

MintKeyphase and others added 5 commits April 13, 2026 19:13

Apply suggestion from @gemini-code-assist[bot]

d4c8726

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Apply suggestion from @gemini-code-assist[bot]

51abc92

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Fixing issue found by Codex

f220bfa

Update detector.ts

8104525

fix second issue from codex

01143cd

~~I blame Gemini~~

chatgpt-codex-connector Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

MintKeyphase added 2 commits April 13, 2026 19:27

Forgot to remove fix

8a87aee

whoops

Hopefully fixes P0 error found by codex

9cd336d

chatgpt-codex-connector Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

Update audio analysis method in detector.ts

31ff4ff

Refactor audio data analysis method and remove async.

chatgpt-codex-connector Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

MintKeyphase added 2 commits April 13, 2026 20:02

changed fallback start location

d65bdc3

Fixing the worklet part for the third time

a6f1855

Thanks Codex

chatgpt-codex-connector Bot reviewed Apr 13, 2026

View reviewed changes

MintKeyphase added 2 commits April 13, 2026 20:23

fixing analyzeChunk call to use options object

9de0bec

Thanks codex, again.

little fix

6e606c2

chatgpt-codex-connector Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

Comment thread packages/stage-shared/src/beat-sync/detector.ts

MintKeyphase and others added 3 commits April 13, 2026 20:38

Make createBeatSyncDetector async and adjust start method

8223f7e

Updated createBeatSyncDetector to be asynchronous and modified the start method to call syncMetronome.

Update package.json

93e34bd

Merge branch 'bpm-tracker-mod' of https://github.com/MintKeyphase/air…

24a88bc

…i-beat-sync into bpm-tracker-mod

chatgpt-codex-connector Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/stage-shared/package.json Outdated

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

Comment thread packages/stage-shared/src/beat-sync/detector.ts Outdated

MintKeyphase added 2 commits April 14, 2026 14:37

Fix package.json formatting for audioworklet

b500c77

Fix return and async

1015724

chatgpt-codex-connector Bot reviewed Apr 14, 2026

View reviewed changes

MintKeyphase closed this Apr 22, 2026

Uh oh!

Conversation

MintKeyphase commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issues

Additional Context

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

MintKeyphase Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

MintKeyphase Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

MintKeyphase Apr 14, 2026

Choose a reason for hiding this comment

MintKeyphase commented Apr 13, 2026 •

edited

Loading