-
-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(stage-ui): prevent Kokoro fp32-webgpu hang and fix STT mic device enumeration #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3607b2b
1f7eef3
5b4128d
7d69859
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,6 +108,14 @@ onMounted(async () => { | |
| await providersStore.fetchModelsForProvider(providerId) | ||
|
|
||
| const config = providersStore.getProviderConfig(providerId) | ||
|
|
||
| // Persist a safe default model if none is saved, or if the saved model is fp32-webgpu which | ||
| // is ~700 MB and causes the page to hang indefinitely on first load. Users can switch to | ||
| // larger/WebGPU models manually after the initial download succeeds. | ||
| if (!config.model || config.model === 'fp32-webgpu') { | ||
| config.model = getDefaultKokoroModel(hasWebGPU.value) | ||
|
Comment on lines
+115
to
+116
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This condition rewrites Useful? React with 👍 / 👎. |
||
| } | ||
|
|
||
| const metadata = providersStore.getProviderMetadata(providerId) | ||
| const validationResult = await metadata.validators.validateProviderConfig(config) | ||
| if (validationResult.valid) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
askPermission()call catches errors but doesn't surface them to the user, despite the comment stating that the user will see a warning. If microphone permission is denied, the audio input dropdown will remain empty without any feedback, which can be confusing for users. It's better to capture the error and display it using the existingerrorref so the user understands why the device list is empty.