fix(server-runtime): preserve explicit empty data destinations

[Gujiassh]

Summary

• treat event.data.destinations the same way as event.route.destinations when the property is explicitly present
• preserve explicit empty destination arrays ([]) instead of collapsing them to undefined
• add a regression test for the explicit-empty-data override case

Validation

• pnpm exec vitest run packages/server-runtime/src/middlewares/route.test.ts

This is a follow-up to the routing edge case discussed on #1621.

[github-actions]

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name	Link
🔭 Waiting for approval	For maintainers, approve here

Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

[gemini-code-assist]

Code Review

This pull request updates the collectDestinations function to correctly handle explicit empty destination lists as overrides and adds a corresponding test case. A review comment identifies a potential runtime error when using the in operator on primitive types and suggests a safer check.

[gemini-code-assist]

The in operator will throw a TypeError if data is a primitive value (such as a string or boolean). Since event.data can be any type depending on the specific event, it is safer to verify that data is a non-null object before performing this check to avoid potential runtime crashes.

Suggested change

	if (data && 'destinations' in data) {
	if (data && typeof data === 'object' && 'destinations' in data) {

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2eef8fb8b8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Guard destination lookup against primitive payloads

collectDestinations now uses data && 'destinations' in data, but event.data is only parsed/cast (not schema-validated) before routing, so malformed events like {"type":"unknown","data":"x"} can reach this path and make the in operator throw a TypeError on a primitive. That turns an otherwise ignorable invalid message into an uncaught runtime failure during message handling; the previous optional-chaining check did not throw in this scenario.

Useful? React with 👍 / 👎.

[nekomeowww]

@copilot resolve the merge conflicts in this pull request

[Gujiassh]

Rebased this branch onto current main to resolve the merge conflict, and I also addressed the remaining runtime guard concern from review.\n\nUpdated head: d3677d04\n- rebased the branch onto latest main\n- kept explicit empty data.destinations = [] as the override\n- guarded collectDestinations against truthy primitive event.data values before using the in operator\n- added a regression test for primitive payloads\n\nValidation:\n- pnpm exec vitest run packages/server-runtime/src/middlewares/route.test.ts

[Gujiassh]

Follow-up update on the current branch head c4be8a3e.

I narrowed the destination override typing so collectDestinations() only returns array-shaped overrides, and removed the duplicate empty-route regression block from the route middleware tests.

Focused verification on the refreshed head:

• pnpm exec vitest run packages/server-runtime/src/middlewares/route.test.ts
• pnpm run typecheck (the workspace still has unrelated package-level dependency resolution noise, but packages/server-runtime now completes as Done, which clears the three collectDestinations type errors from the previous CI failure)