Add feature: auto hide controls island by leaft · Pull Request #1534 · moeru-ai/airi

leaft · 2026-03-31T17:03:36Z

Description

为控制岛添加自动隐藏功能，可以设置隐藏delay、展示delay、隐藏时的透明度
同时删除了暂时无用的 controlslandIconSetting
提取hooks，使用 setTimeout 处理自动隐藏延迟和菜单折叠

Linked Issues

Additional Context

github-actions · 2026-03-31T17:04:01Z

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name	Link
🔭 Waiting for approval	For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

gemini-code-assist

Code Review

This pull request introduces several significant updates, including a version bump to 0.9.0-beta.2, the addition of a power monitor service for Electron, and a new expression controller for Live2D models. It also refactors the speech pipeline to support concurrent TTS generation and implements a consumer registration system for event delivery. My feedback focuses on potential performance and architectural concerns: the global Cache-Control middleware may be too broad, the speech pipeline's concurrency management could be optimized, and the consumer selection logic in the server runtime should be monitored for scalability as the number of connected modules increases.

gemini-code-assist · 2026-03-31T17:08:31Z

+    .use('*', async (c, next) => {
+      await next()
+
+      // NOTICE: All API responses should be non-cacheable. Auth responses can
+      // carry session state through redirects, and stale API payloads are not
+      // safe to serve from edge caches after user/account mutations.
+      c.res.headers.set('Cache-Control', 'no-store, no-cache, private, max-age=0')
+      c.res.headers.set('Pragma', 'no-cache')
+      c.res.headers.set('Expires', '0')
+    })


Setting Cache-Control headers globally on all routes might be too aggressive. Consider if this should be applied to specific API routes instead of the entire application, as it could negatively impact performance for static assets or public data.

gemini-code-assist · 2026-03-31T17:08:31Z

+        while (!intent.controller.signal.aborted && inFlightTasks.size >= ttsMaxConcurrent) {
+          await Promise.race(inFlightTasks)
+        }


The while loop condition inFlightTasks.size >= ttsMaxConcurrent might cause a busy-wait if Promise.race resolves quickly. Consider using a more efficient semaphore or queue-based approach to manage concurrency.

gemini-code-assist · 2026-03-31T17:08:31Z

+      const selectedConsumer = selectConsumer(event, peer.id, delivery)
+      if (delivery && (delivery.mode === 'consumer' || delivery.mode === 'consumer-group')) {
+        if (!selectedConsumer) {
+          logger.withFields({ peer: peer.id, peerName: p.name, event, delivery }).warn('no consumer registered for event delivery')
+          if (delivery.required) {
+            send(peer, RESPONSES.error(ServerErrorMessages.noConsumerRegistered, instanceId, event.metadata?.event.id))
+          }
+          return
+        }
+
+        try {
+          logger.withFields({
+            fromPeer: peer.id,
+            fromPeerName: p.name,
+            toPeer: selectedConsumer.peer.id,
+            toPeerName: selectedConsumer.name,
+            event,
+            delivery,
+          }).debug('sending event to selected consumer')
+
+          selectedConsumer.peer.send(payload)
+        }
+        catch (err) {
+          logger.withFields({
+            fromPeer: peer.id,
+            fromPeerName: p.name,
+            toPeer: selectedConsumer.peer.id,
+            toPeerName: selectedConsumer.name,
+            event,
+            delivery,
+          }).withError(err).error('failed to send event to selected consumer, removing peer')
+
+          peers.delete(selectedConsumer.peer.id)
+          unregisterModulePeer(selectedConsumer, 'consumer send failed')
+        }
+        return
+      }


The selectConsumer logic is called within the main request loop. Ensure that the consumerRegistry and peers maps are efficiently indexed to prevent performance degradation as the number of connected modules grows.

Add configurable auto-hide feature for controls island: - autoHideControlsIsland: toggle to enable/disable - autoHideDelay: delay before hiding (0-60s, default 5s) - autoShowDelay: delay before showing after mouse enters (0-5s, default 0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

… styles

…geTamagotchi

gemini-code-assist

Code Review

This pull request implements an auto-hide feature for the controls island, allowing users to configure show/hide delays and hidden opacity levels. The changes include refactoring the settings store, adding unit tests, and updating the settings UI. Feedback highlights a logic flaw where the island collapses immediately upon mouse exit, disregarding the configured delay, and suggests utilizing refDebounced for a more robust implementation. Additionally, the reviewer pointed out several hardcoded strings in the UI that should be migrated to i18n translation keys to maintain localization standards.

gemini-code-assist · 2026-03-31T17:18:25Z

+watch(isOutside, (outside) => {
+  lastUpdateTime = Date.now()
+  timeSinceOutside.value = 0
+  timeSinceInside.value = 0
+
  if (outside && expanded.value && !isBlocked.value) {
    expanded.value = false
  }


此处的 watch 逻辑在鼠标移出时立即将 expanded 设为 false，这会导致菜单立即折叠，忽略了用户设置的 autoHideDelay 延迟。建议移除此处的立即折叠逻辑，并恢复使用 refDebounced 来实现符合预期的延迟折叠行为。

watch(isOutside, () => { lastUpdateTime = Date.now() timeSinceOutside.value = 0 timeSinceInside.value = 0 }) const isOutsideAfterDelay = refDebounced(isOutside, autoHideDelayMs) watch(isOutsideAfterDelay, (outside) => { if (outside && expanded.value && !isBlocked.value) { expanded.value = false } })

gemini-code-assist · 2026-03-31T17:18:25Z

+import { useSettings, useSettingsAudioDevice, useSettingsControlsIsland } from '@proj-airi/stage-ui/stores/settings'
 import { useTheme } from '@proj-airi/ui'
-import { refDebounced, useIntervalFn } from '@vueuse/core'
+import { useIntervalFn } from '@vueuse/core'


建议保留 refDebounced 的导入。它在处理基于延迟的状态变化（如自动折叠菜单）时，比手动计时或轮询更简洁且精确。

import { refDebounced, useIntervalFn } from '@vueuse/core'

gemini-code-assist · 2026-03-31T17:18:25Z

    expanded.value = false
  }
-}, 1500)
+}, () => autoHideDelayMs.value || 5000)


如果采用了基于 refDebounced 的监听逻辑，这个 useIntervalFn 将变得冗余。此外，使用轮询来实现延迟逻辑不够精确，建议清理。

gemini-code-assist · 2026-03-31T17:18:25Z

+      label="Auto-hide controls island"
+      description="Hide controls island after mouse leaves, show after mouse enters"


此处使用了硬编码的字符串。为了保持项目的一致性并支持多语言，请使用 t() 函数配合 i18n 翻译键。

:label="t('settings.controls-island.auto-hide.title')" :description="t('settings.controls-island.auto-hide.description')"

gemini-code-assist · 2026-03-31T17:18:25Z

+        :max="5"
+        :step="0.1"
+        :format-value="v => `${v}s`"
+        label="Hide delay"


此处使用了硬编码的字符串。请使用 i18n 翻译键。

:label="t('settings.controls-island.auto-hide.hide-delay')"

gemini-code-assist · 2026-03-31T17:18:25Z

+        :max="5"
+        :step="0.1"
+        :format-value="v => `${v}s`"
+        label="Show delay"


此处使用了硬编码的字符串。请使用 i18n 翻译键。

:label="t('settings.controls-island.auto-hide.show-delay')"

gemini-code-assist · 2026-03-31T17:18:25Z

+        :max="100"
+        :step="1"
+        :format-value="v => `${v}%`"
+        label="Hidden opacity"


此处使用了硬编码的字符串。请使用 i18n 翻译键。

:label="t('settings.controls-island.auto-hide.opacity')"

…ved delay handling

…lay handling

…ings

…or improved delay handling

…les for improved UI behavior

leaft · 2026-04-01T11:06:25Z

/gemini review

gemini-code-assist

Code Review

This pull request implements auto-hide and auto-collapse functionality for the controls island, replacing manual debounce logic with dedicated composables (useControlsIslandAutohide and useControlsIslandCollapse). The settings store and UI are updated to support configurable hide/show delays and opacity, while the previous icon size setting is removed in favor of static styling. Review feedback recommends using internationalization for new UI labels and exposing the new settings in the main settings store for consistency.

gemini-code-assist · 2026-04-01T11:08:55Z

+      label="Auto-hide controls island"
+      description="Hide controls island after mouse leaves, show after mouse enters"


这里的 label 和 description 使用了硬编码的英文文本。建议使用 t() 函数并引用语言包中的键值。但请注意，如果这些硬编码值是临时性的且未来可能独立修改，根据项目规则，建议保持它们独立以方便后续调整，避免过早进行抽象。

References

Avoid abstracting duplicated hardcoded values into a constant if they are temporary and intended to be replaced individually. Keeping them separate can improve visibility and simplify future modifications.

gemini-code-assist · 2026-04-01T11:08:55Z

    allowVisibleOnAllWorkspaces: controlsIslandRefs.allowVisibleOnAllWorkspaces,
    alwaysOnTop: controlsIslandRefs.alwaysOnTop,


虽然 useSettings 已被标记为弃用，但作为统一的设置入口，建议也将新增加的自动隐藏相关设置项（autoHideControlsIsland, autoHideDelay, autoShowDelay, autoHideOpacity）同步暴露出来，以保持接口的一致性。在处理这些 UI 隐藏相关的设置时，请注意根据背景类型进行审美适配。

Suggested change

allowVisibleOnAllWorkspaces: controlsIslandRefs.allowVisibleOnAllWorkspaces,

alwaysOnTop: controlsIslandRefs.alwaysOnTop,

allowVisibleOnAllWorkspaces: controlsIslandRefs.allowVisibleOnAllWorkspaces,

alwaysOnTop: controlsIslandRefs.alwaysOnTop,

autoHideControlsIsland: controlsIslandRefs.autoHideControlsIsland,

autoHideDelay: controlsIslandRefs.autoHideDelay,

autoShowDelay: controlsIslandRefs.autoShowDelay,

autoHideOpacity: controlsIslandRefs.autoHideOpacity,

References

Conditionally hide UI elements that clash aesthetically with certain background types, such as custom images.

…rolsIslandCollapse composables

…amline timeout function

…elated tests

…sed)

…ed useSettings Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

leaft · 2026-04-02T08:19:13Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces an auto-hide and auto-collapse feature for the Tamagotchi stage controls island. It includes new Pinia store settings for hide/show delays and opacity, two new composables (useControlsIslandAutoHide and useControlsIslandCollapse) to manage the logic, and corresponding UI updates in the settings panel. A potential issue was identified in the auto-hide logic where rapid mouse movements could cause visual flickering due to immediate state resets in the watcher; a refactoring of the timer logic is suggested to ensure smoother transitions.

gemini-code-assist · 2026-04-02T08:22:03Z

+  const isOutsideDelayed = ref(isOutside.value)
+  const isInsideDelayed = ref(!isOutside.value)
+
+  // --- Auto-hide island (only works when autoHideControlsIsland = true) ---
+  const { start: startOutside, stop: stopOutside } = useTimeoutFn(() => {
+    isOutsideDelayed.value = true
+  }, () => autoHideDelay.value * 1000, { immediate: false })
+
+  const { start: startInside, stop: stopInside } = useTimeoutFn(() => {
+    isInsideDelayed.value = true
+  }, () => autoShowDelay.value * 1000, { immediate: false })
+
+  // Watch mouse position changes
+  watch(isOutside, (val) => {
+    if (!autoHideControlsIsland.value) {
+      // Not in auto-hide mode, reset states
+      stopOutside()
+      stopInside()
+      isOutsideDelayed.value = val
+      isInsideDelayed.value = !val
+      return
+    }
+    stopOutside()
+    stopInside()
+    if (val) {
+      // Mouse left - start hide delay timer
+      isInsideDelayed.value = false
+      startOutside()
+    }
+    else {
+      // Mouse entered - start show delay timer
+      isOutsideDelayed.value = false
+      startInside()
+    }
+  })


The current implementation of the auto-hide logic can cause the island to flicker (briefly hide and then show) when the mouse moves quickly out and back into the island area. This happens because isInsideDelayed and isOutsideDelayed are reset immediately in the isOutside watcher, which affects the isHidden computed property before the timers have a chance to fire.

Refactoring the logic to only update these states when the respective delays are met (or when the feature is disabled) provides a smoother user experience and avoids unnecessary state transitions during quick mouse movements.

const isOutsideDelayed = ref(isOutside.value) const isInsideDelayed = ref(!isOutside.value) // --- Auto-hide island (only works when autoHideControlsIsland = true) --- const { start: startOutside, stop: stopOutside } = useTimeoutFn(() => { isOutsideDelayed.value = true isInsideDelayed.value = false }, () => autoHideDelay.value * 1000, { immediate: false }) const { start: startInside, stop: stopInside } = useTimeoutFn(() => { isInsideDelayed.value = true isOutsideDelayed.value = false }, () => autoShowDelay.value * 1000, { immediate: false }) // Watch mouse position changes watch(isOutside, (val) => { stopOutside() stopInside() if (!autoHideControlsIsland.value) { // Not in auto-hide mode, reset states isOutsideDelayed.value = val isInsideDelayed.value = !val return } if (val) { // Mouse left - start hide delay timer if it was shown if (isInsideDelayed.value) startOutside() } else { // Mouse entered - start show delay timer if it was hidden if (isOutsideDelayed.value) startInside() } })

Only update delayed states when the respective delays are met (or when delay is 0), avoiding unnecessary state transitions during rapid mouse movements in/out of the island area. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

gemini-code-assist bot reviewed Mar 31, 2026

View reviewed changes

leaft force-pushed the add-settings-auto-hide-controls-island branch from 6a149c7 to c6035c9 Compare March 31, 2026 17:08

leaft and others added 6 commits April 1, 2026 01:10

feat(stage-tamagotchi): watch show delay and hide delay

bcdbad7

feat(settings): add auto-hide opacity setting for controls island

2f5562b

feat(settings): remove controls island icon size setting and simplify…

98981fd

… styles

feat(settings): update auto-hide controls island setting to use isSta…

91c6ad2

…geTamagotchi

feat(tests): add unit tests for settings-controls-island store

a2b65bc

leaft force-pushed the add-settings-auto-hide-controls-island branch from c6035c9 to a2b65bc Compare March 31, 2026 17:10

gemini-code-assist bot reviewed Mar 31, 2026

View reviewed changes

leaft added 2 commits April 1, 2026 01:41

feat(settings): refactor auto-hide logic using refDebounced for impro…

a41440a

…ved delay handling

feat(settings): update auto-hide logic to use computed for dynamic de…

b944bd8

…lay handling

leaft force-pushed the add-settings-auto-hide-controls-island branch from 1f30a0d to b944bd8 Compare March 31, 2026 18:53

leaft added 4 commits April 1, 2026 03:35

feat(settings): update auto-hide delay logic to use configurable sett…

0597d3f

…ings

feat(stage-ui): remove redundant background color class from island div

c29304c

feat(controls-island): refactor auto-hide logic to use useTimeoutFn f…

577b945

…or improved delay handling

feat(controls-island): implement auto-hide and auto-collapse composab…

a0e185e

…les for improved UI behavior

gemini-code-assist bot reviewed Apr 1, 2026

View reviewed changes

leaft and others added 6 commits April 1, 2026 19:12

fix(controls-island): correct import name for auto-hide composable

72492c1

feat(tests): add unit tests for useControlsIslandAutoHide and useCont…

4c4ea5c

…rolsIslandCollapse composables

refactor(useControlsIslandAutoHide): remove unused variables and stre…

33ea17a

…amline timeout function

feat(controls-island): add useControlsIslandCollapse composable and r…

6018619

…elated tests

[claudesquad] update from 'beautify-feat' on 02 Apr 26 15:47 CST (pau…

a76fb38

…sed)

feat(settings): expose auto-hide controls island settings in deprecat…

9d35be2

…ed useSettings Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

gemini-code-assist bot reviewed Apr 2, 2026

View reviewed changes

nekomeowww added the scope/ui Scope related to UI/UX, or interface improve, perf, and bugs label Apr 7, 2026

nekomeowww added feature Related to feature priority/nice-to-have Issue, or Pull Request that nice to have but can be handled later labels Apr 7, 2026

		label="Auto-hide controls island"
		description="Hide controls island after mouse leaves, show after mouse enters"

		allowVisibleOnAllWorkspaces: controlsIslandRefs.allowVisibleOnAllWorkspaces,
		alwaysOnTop: controlsIslandRefs.alwaysOnTop,

Uh oh!

Conversation

leaft commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issues

Additional Context

Uh oh!

github-actions bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

leaft commented Apr 1, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

leaft commented Apr 2, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leaft commented Mar 31, 2026 •

edited

Loading

github-actions bot commented Mar 31, 2026 •

edited

Loading