feat(cellbudgetfile): support aux vars with full3D in get_data()#2776
Draft
wpbonelli wants to merge 2 commits into
Draft
feat(cellbudgetfile): support aux vars with full3D in get_data()#2776wpbonelli wants to merge 2 commits into
wpbonelli wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2776 +/- ##
===========================================
+ Coverage 55.5% 72.5% +17.0%
===========================================
Files 644 677 +33
Lines 124135 132649 +8514
===========================================
+ Hits 68947 96287 +27340
+ Misses 55188 36362 -18826
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
variableparameter (default "q") toget_data()andget_record()to allow specifying the field to extract to a 3D grid-shaped array. Previously "q" was returned unconditionally.variableis only supported whenfull3D=Trueand the method's default behavior is unchanged.This is consistent with the existing
variableparameter inget_ts(), added in #2568Close #2774.