Skip to content

Add richer OTel MCP span attributes #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kludex wants to merge 5 commits into
base: main
Choose a base branch
from

Inline OTel span attributes

b5b5389
Select commit
Loading
Failed to load commit list.
Open

Add richer OTel MCP span attributes #2387

Inline OTel span attributes
b5b5389
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 3, 2026 in 14m 5s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit tests/shared/test_otel.py:53-80 mcp.session.id span attribute is untested; promised test does not exist

Annotations

Check warning on line 80 in tests/shared/test_otel.py

See this annotation in the file changed.

@claude claude / Claude Code Review

mcp.session.id span attribute is untested; promised test does not exist 

The PR description instructs running pytest with a filter for resource_read_spans_include_session_id, but no such test exists anywhere in the test suite. As a result, the mcp.session.id span attribute added in _handle_request has zero test coverage: all new tests use the in-process Client(server) transport where message.message_metadata carries no HTTP request context, so session_id is always None and the attribute-setting branch is never exercised. A regression in the header extraction logic wo
View more details on Claude