DRAFT: feat: webview commands for listing and evaluating js #229
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package agents | ||
|
|
||
| import _ "embed" | ||
|
|
||
| //go:embed android/devicekit.so | ||
| var AndroidDevicekitSO []byte | ||
|
|
||
| //go:embed android/devicekit.dex | ||
| var AndroidDevicekitDEX []byte | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,262 @@ | ||
| package cli | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/mobile-next/mobilecli/commands" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| var webviewCmd = &cobra.Command{ | ||
| Use: "webview", | ||
| Short: "Inspect and interact with embedded webviews", | ||
| Long: `List, navigate, evaluate JavaScript, and inspect DOM content inside embedded webviews on a device.`, | ||
| } | ||
|
|
||
| var webviewListCmd = &cobra.Command{ | ||
| Use: "list", | ||
| Short: "List embedded webviews on a device", | ||
| Long: `Returns all embedded webviews currently visible in the foreground app. Browser apps (Safari, Chrome) are not included.`, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewListCommand(commands.WebViewListRequest{ | ||
| DeviceID: deviceId, | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| var webviewGotoCmd = &cobra.Command{ | ||
| Use: "goto <id> <url>", | ||
| Short: "Navigate a webview to a URL", | ||
| Long: `Navigates the specified webview to the given URL. The webview id comes from 'webview list'.`, | ||
| Args: cobra.ExactArgs(2), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewGotoCommand(commands.WebViewGotoRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| URL: args[1], | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| var webviewReloadCmd = &cobra.Command{ | ||
| Use: "reload <id>", | ||
| Short: "Reload a webview", | ||
| Long: `Reloads the page currently loaded in the specified webview.`, | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewReloadCommand(commands.WebViewReloadRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| var webviewBackCmd = &cobra.Command{ | ||
| Use: "back <id>", | ||
| Short: "Navigate a webview back", | ||
| Long: `Navigates the webview back in its history, equivalent to pressing the browser back button.`, | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewGoBackCommand(commands.WebViewRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| var webviewForwardCmd = &cobra.Command{ | ||
| Use: "forward <id>", | ||
| Short: "Navigate a webview forward", | ||
| Long: `Navigates the webview forward in its history, equivalent to pressing the browser forward button.`, | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewGoForwardCommand(commands.WebViewRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| var webviewEvalCmd = &cobra.Command{ | ||
| Use: "eval <id> <expression>", | ||
| Short: "Evaluate JavaScript in a webview", | ||
| Long: `Evaluates a JavaScript expression in the context of the specified webview and returns the result.`, | ||
| Args: cobra.ExactArgs(2), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewEvaluateCommand(commands.WebViewEvaluateRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| Expression: args[1], | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| var webviewWaitCmd = &cobra.Command{ | ||
| Use: "wait <id>", | ||
| Short: "Wait for a webview to finish loading", | ||
| Long: `Waits for the webview to reach the specified load state before returning.`, | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewWaitForLoadStateCommand(commands.WebViewWaitForLoadStateRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| State: webviewWaitState, | ||
| Timeout: webviewWaitTimeout, | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
|
Comment on lines
+124
to
+141
There was a problem hiding this comment. Validate Right now invalid values are sent downstream; fail fast in CLI to provide immediate feedback. 🛡️ Suggested fix RunE: func(cmd *cobra.Command, args []string) error {
+ switch webviewWaitState {
+ case "load", "domcontentloaded":
+ default:
+ return fmt.Errorf("invalid --state %q (allowed: load, domcontentloaded)", webviewWaitState)
+ }
+ if webviewWaitTimeout < 0 {
+ return fmt.Errorf("--timeout must be >= 0")
+ }
+
response := commands.WebViewWaitForLoadStateCommand(commands.WebViewWaitForLoadStateRequest{
DeviceID: deviceId,
WebViewID: args[0],
State: webviewWaitState,
Timeout: webviewWaitTimeout,
})
- printJson(response)
- if response.Status == "error" {
- return fmt.Errorf("%s", response.Error)
- }
- return nil
+ return printAndReturnError(response)
},Also applies to: 256-257 🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| // ─── Convenience commands built on evaluate ─────────────────── | ||
|
|
||
| var webviewURLCmd = &cobra.Command{ | ||
| Use: "url <id>", | ||
| Short: "Print the current URL of a webview", | ||
| Long: `Prints the current URL loaded in the specified webview.`, | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewEvaluateCommand(commands.WebViewEvaluateRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| Expression: "location.href", | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
|
Comment on lines
+146
to
+162
Member
There was a problem hiding this comment.
Fine for now, but worth documenting this in the |
||
| } | ||
|
|
||
| var webviewTitleCmd = &cobra.Command{ | ||
| Use: "title <id>", | ||
| Short: "Print the title of a webview", | ||
| Long: `Prints the document title of the page currently loaded in the specified webview.`, | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewEvaluateCommand(commands.WebViewEvaluateRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| Expression: "document.title", | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| var webviewContentCmd = &cobra.Command{ | ||
| Use: "content <id>", | ||
| Short: "Dump the HTML content of a webview", | ||
| Long: `Returns the full outer HTML of the page currently loaded in the specified webview.`, | ||
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| response := commands.WebViewEvaluateCommand(commands.WebViewEvaluateRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| Expression: "document.documentElement.outerHTML", | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| var webviewQueryCmd = &cobra.Command{ | ||
| Use: "query <id> <selector>", | ||
| Short: "Query DOM elements in a webview", | ||
| Long: `Finds elements matching a CSS selector and returns their tag, text, id, and value. Useful for inspecting webview content.`, | ||
| Args: cobra.ExactArgs(2), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| selector := args[1] | ||
| expression := fmt.Sprintf( | ||
| `Array.from(document.querySelectorAll(%q)).map(el => ({`+ | ||
| `tag: el.tagName.toLowerCase(),`+ | ||
| `text: (el.textContent || "").trim().slice(0, 200),`+ | ||
| `id: el.id || null,`+ | ||
| `class: el.className || null,`+ | ||
| `value: el.value || null,`+ | ||
| `href: el.href || null`+ | ||
| `}))`, | ||
| selector, | ||
| ) | ||
| response := commands.WebViewEvaluateCommand(commands.WebViewEvaluateRequest{ | ||
| DeviceID: deviceId, | ||
| WebViewID: args[0], | ||
| Expression: expression, | ||
| }) | ||
| printJson(response) | ||
| if response.Status == "error" { | ||
| return fmt.Errorf("%s", response.Error) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| func init() { | ||
| rootCmd.AddCommand(webviewCmd) | ||
|
|
||
| webviewCmd.AddCommand(webviewListCmd) | ||
| webviewCmd.AddCommand(webviewGotoCmd) | ||
| webviewCmd.AddCommand(webviewReloadCmd) | ||
| webviewCmd.AddCommand(webviewBackCmd) | ||
| webviewCmd.AddCommand(webviewForwardCmd) | ||
| webviewCmd.AddCommand(webviewEvalCmd) | ||
| webviewCmd.AddCommand(webviewWaitCmd) | ||
| webviewCmd.AddCommand(webviewURLCmd) | ||
| webviewCmd.AddCommand(webviewTitleCmd) | ||
| webviewCmd.AddCommand(webviewContentCmd) | ||
| webviewCmd.AddCommand(webviewQueryCmd) | ||
|
|
||
| webviewListCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewGotoCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewReloadCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewBackCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewForwardCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewEvalCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewWaitCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewWaitCmd.Flags().StringVar(&webviewWaitState, "state", "load", `load state to wait for: "load" or "domcontentloaded"`) | ||
| webviewWaitCmd.Flags().IntVar(&webviewWaitTimeout, "timeout", 0, "maximum time to wait in milliseconds (0 = default)") | ||
| webviewURLCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewTitleCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewContentCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| webviewQueryCmd.Flags().StringVar(&deviceId, "device", "", "ID of the device") | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: mobile-next/mobilecli
Length of output: 1958
🏁 Script executed:
Repository: mobile-next/mobilecli
Length of output: 82
🏁 Script executed:
Repository: mobile-next/mobilecli
Length of output: 239
🏁 Script executed:
Repository: mobile-next/mobilecli
Length of output: 289
Missing embed targets cause compile failure
Both
android/devicekit.so(line 5) andandroid/devicekit.dex(line 8) are missing from the repository. The//go:embeddirectives will fail at build time until these artifacts are added.🧰 Tools
🪛 GitHub Check: test
[failure] 8-8:
pattern android/devicekit.dex: no matching files found
🤖 Prompt for AI Agents