Skip to content

Fix motion tracker shapes not properly clipping out of frame #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doruphin wants to merge 9 commits into
base: master
Choose a base branch
from
+37 −35
Open

Fix motion tracker shapes not properly clipping out of frame #1279

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fa62874
changed in place blurring to buffer
doruphin Jul 30, 2026
d452d45
unnecessary copy and change constant to enum
doruphin Jul 31, 2026
72bf9d8
change existing value to enum
doruphin Jul 31, 2026
10c125b
correctly draws clipped shape
doruphin Aug 4, 2026
153fda6
fix crash by checking if blur region exists
doruphin Aug 4, 2026
d6b3956
fix pixelate crash
doruphin Aug 4, 2026
2ecc3cb
operations optimization
doruphin Aug 4, 2026
9defcbb
Merge branch 'master' into tracker_clip_shapes_out_of_frame
ddennedy Aug 4, 2026
646dc76
proper arguments for cv::resize
doruphin Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 35 additions & 35 deletions src/modules/opencv/filter_opencv_tracker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,59 +445,39 @@ static int filter_get_image(mlt_frame frame,
position,
data->producer_in + data->producer_length);
}
// ensure bounding box is within the frame boundaries or OpenCV will crash
if (data->boundingBox.x > *width) {
data->boundingBox.x = *width;
data->boundingBox.width = 0;
} else if (data->boundingBox.x < 0) {
data->boundingBox.width = MAX(0, data->boundingBox.width + data->boundingBox.x);
data->boundingBox.x = 0;
}
if (data->boundingBox.y > *height) {
data->boundingBox.y = *height;
data->boundingBox.height = 0;
} else if (data->boundingBox.y < 0) {
data->boundingBox.height = MAX(0, data->boundingBox.height + data->boundingBox.y);
data->boundingBox.y = 0;
}
if (data->boundingBox.x + data->boundingBox.width > *width) {
data->boundingBox.width = *width - data->boundingBox.x;
}
if (data->boundingBox.y + data->boundingBox.height > *height) {
data->boundingBox.height = *height - data->boundingBox.y;
}

if (blur > 0 && data->boundingBox.width > 1 && data->boundingBox.height > 1) {
cv::Rect clippedBox = data->boundingBox & cv::Rect(0, 0, *width, *height);
if (blur > 0 && clippedBox.width > 1 && clippedBox.height > 1) {
cv::Mat roi = cvFrame(clippedBox);
cv::Mat blurredRoi;
bool do_blur = true;

switch (mlt_properties_get_int(filter_properties, "blur_type")) {
case 1:
// Gaussian Blur
cv::GaussianBlur(cvFrame(data->boundingBox),
cvFrame(data->boundingBox),
cv::Size(0, 0),
blur);
cv::GaussianBlur(roi, blurredRoi, cv::Size(0, 0), blur);
break;
case 2:
// Pixelate
{
cv::Mat roi = cvFrame(data->boundingBox);
cv::Mat res;
cv::resize(roi,
res,
cv::Size(MAX(2, data->boundingBox.width / blur),
MAX(2, data->boundingBox.height / blur)),
cv::Size(MAX(2, clippedBox.width / blur),
MAX(2, clippedBox.height / blur)),
cv::INTER_NEAREST);
Comment thread
ddennedy marked this conversation as resolved.
cv::resize(res,
roi,
cv::Size(data->boundingBox.width, data->boundingBox.height),
blurredRoi,
cv::Size(clippedBox.width, clippedBox.height),
0,
0,
cv::INTER_NEAREST);
cvFrame(data->boundingBox) = roi;
}
break;
case 3:
// Opaque fill, handled in shape_width option
shape_width = -1;
do_blur = false;
break;
case 0:
// Median Blur
Expand All @@ -506,12 +486,32 @@ static int filter_get_image(mlt_frame frame,
// median blur param must be odd and, minimum 3
++blur;
}
cv::medianBlur(cvFrame(data->boundingBox), cvFrame(data->boundingBox), blur);
cv::medianBlur(roi, blurredRoi, blur);
break;
default:
// Do nothing
do_blur = false;
break;
}

if (do_blur) {
switch (mlt_properties_get_int(filter_properties, "shape")) {
case 1:
// Ellipse
{
cv::Mat mask = cv::Mat::zeros(roi.size(), CV_8UC1);
cv::RotatedRect bounding = cv::RotatedRect(cv::Point2f(data->boundingBox.x + data->boundingBox.width / 2.0f - clippedBox.x,
data->boundingBox.y + data->boundingBox.height / 2.0f - clippedBox.y),
cv::Size2f(data->boundingBox.width, data->boundingBox.height),
0);
cv::ellipse(mask, bounding, cv::Scalar(255), -1, cv::LINE_4);
blurredRoi.copyTo(roi, mask);
}
break;
default:
blurredRoi.copyTo(roi);
break;
}
}
}

// Paint overlay shape
Expand Down Expand Up @@ -546,7 +546,7 @@ static int filter_get_image(mlt_frame frame,
bounding,
cv::Scalar(shape_color.r, shape_color.g, shape_color.b),
shape_width,
1);
cv::LINE_4);
}
break;
case 0:
Expand Down
Loading